From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCCDB44BCA5 for ; Thu, 2 Jul 2026 12:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782996290; cv=none; b=VW7O367ptTICg1yQgcBBNOuPPDHHv+jlwCIRAFKZvQwc8bILUz8BaDbxdFgyz/bW0MDCZtxtjNRg3sDhqMkYom6vKMU/oiZQpAYF46NsaGaCu24R3/GOTwK50EgI32fGhrH8a2r9NkQN4+mFG8GBhbBecnJXGKlzJxygTTDAApg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782996290; c=relaxed/simple; bh=M3vT7WHrqcyejJBhB2rh+AJHUnKETdP4JrfL0b19uc8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=UE+Zj0Ndzt+rOzUP6ZPjIXaAaeth2m+fMVPJDJ8Rp2baNjN+e27n+U1u3uBBzZGxpQg6LBdnOdqVAXwQT8WxAjdQNM854DyxNtD/YpwE77AWsuWQ/dUPqjzp8I2CeIDsqbfinRL9ouKPwisV9rZZZY1svsdo7g8EPRoDqnJU13Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ofOsqDiF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dzTUQ6kA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ofOsqDiF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dzTUQ6kA" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 662C3cJ8389758 for ; Thu, 2 Jul 2026 12:44:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f1ZbIlmrnZBF09IpMi+cBnqnyYuuLrnreaKCM9hEs4M=; b=ofOsqDiF5W5H4TXF PKVn4pHc19o2vqLMRkQmtkUMhC8SrYqHjoehuBkMHQZNpSJMDYeMzOTpFZ37c1gK 33LcQhjatOM+TNUYG7pCnQzlJN1MApA8hjGRSog1gEuJVWMqfBg6PTXrcatth3Zi 9x42BtelPEXrT4B6bi4Yy7TDmwgUOewYkJS7cUg+CrXRDJR8wR3aUCmJ5OUPGcD2 nDiVhv+yfI/A3zntPheW0dQM0D0OJ+ltQJHiEG7C66tZexPu+kD7DUssgHnFuMAX NFA/jJFo/X6rFvqsXH7Du3dukrTrRBbMOVodRIybwT8qmHVK7eEoscilcKu5HqA6 d6Iyog== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5qnp85wb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 12:44:47 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c267931ebso6939321cf.2 for ; Thu, 02 Jul 2026 05:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782996287; x=1783601087; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=f1ZbIlmrnZBF09IpMi+cBnqnyYuuLrnreaKCM9hEs4M=; b=dzTUQ6kAGfYVLq9oXIcbTb60ynWvg62EXPBtth63LLTqoFd8i2GZMyg9EI1AT8x9HR TzQz6JV1mvDHXI90e0d1zuJCoI6uhhBnJDjVVdcBoDkGTONRZBnbwBhkP6qE4gfAPD5h dnplvLaziJQAJSROG5+U0oJ/9S7XANIFG728UZY5suC3cl/O/mA7lEGUttfWdCo/PC/C 3aeHgo9IMqaaFMG3VKSzYCJpsTU53jWc7yVs0kxWDeoNYgy/i2JUyraFjiIliGEZeHwR 70LKJNb7HXe8Qr2GqccfWPLq6fnvVSoqEb4UzNBucRrgCS1N8JZjmEyBfVCxmK6a09BZ Hv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782996287; x=1783601087; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f1ZbIlmrnZBF09IpMi+cBnqnyYuuLrnreaKCM9hEs4M=; b=IBiP1Fpm64yNa1khby7nyiyOxZt5QXv5Txw6RojUdr74KhBnSkSjNfu0/MYfI5rIZU KdOpbaJrPgP1ZDHyTa+he0phntT31BDFQXkkORc6UoBw1nzeSzlarAnBBsAmuVdAfkCT dDAyV1GutloEEuMyvcTbs+NNtZurt7fyRoReHlLrpuAIOvKQCTUt3uxD6BI0OyrlE3Tl X0vdGhnYuuJqNJR/NDj0VEdQ0SBWN8q7gvTxei7ovW+Xhc9OGS8ACKb1oAXeKXSYt/B4 B51IqL34IX2HzQ9u/SgdHRjFi91DpG6lQrl0mh1Eb5SJv/iNjecmIwhxcRFR8IGXMcXy WrCQ== X-Forwarded-Encrypted: i=1; AFNElJ8/gejnAG5rNOmnFnnr1OJ1YGKziiIS0ynKtos7lGi5nKv948dIH7D39cISL3ig97OQ18LijvpYLFP2kVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxMBzwNF7Hot3oIBzEzuyf052ytkCrSyzXUQzq5ZuBjdNUOSqmU 9qm2hWnhSXFDY7VTJ1p2nWZPgECS10Hvv6exdTZxO2fGfglJMtxdDCm68SL4YC87O/tiyHK5Pge l6I1IJh+oFV1mp1wDk6koyi1TNqGTqQPPPKhuMhMQU6r9un4I2kjY5xLX0oMyn9mdoo8= X-Gm-Gg: AfdE7cl8OuSY0xbNAVMdAltVCcw/+vZEHv/PDX7whwPn8gMRA0HIqc4kpfV9yK7fjKW g4uQMviGN99kFSlRHt/HidN6uvanmofi3ugexToLu1I1qn/yHRmJs9JligcB9grLwpy5YCCifUQ MrofcT2FtjvqMzqWYVqp5mbWl49NEYYifcH0uhonZqurSt2NjWS7Dk6jVdT72s9m12yQ3tjXMa1 JWSEjDx9wMw2wMIU7pFvhYOFyTlr/Sw/HDIHfKjAq+Lo7RKL45C+Zsp896WQ1vhfIydfHg28Q9b 6XdT8YF+Pa8gnm0mYn7XCaIb/pSW6KYgj4A5I9FgOHDPgkQs0nLxitTbFmdgBlCHjyHzMaQ2Ab3 Oc9X6jyZX8nZW1pPsKw5BLuml2x4b+mDI66s= X-Received: by 2002:a05:622a:14d1:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51c26b42202mr46905701cf.11.1782996287018; Thu, 02 Jul 2026 05:44:47 -0700 (PDT) X-Received: by 2002:a05:622a:14d1:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51c26b42202mr46905361cf.11.1782996286440; Thu, 02 Jul 2026 05:44:46 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-698ace16064sm936580a12.2.2026.07.02.05.44.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 05:44:45 -0700 (PDT) Message-ID: <6fbc4521-15d3-40c7-89b3-ee15ad673ff8@oss.qualcomm.com> Date: Thu, 2 Jul 2026 14:44:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode From: Konrad Dybcio To: Pengyu Luo , Mukesh Savaliya Cc: Dmitry Baryshkov , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260614083424.464132-1-mitltlatltl@gmail.com> <20260614083424.464132-2-mitltlatltl@gmail.com> <99eaf1d1-fbf9-4336-a13c-ae8ab789cc99@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEzMyBTYWx0ZWRfX6kUWUbHxF/ip FgqHB0likjI2fuK/jZz6niQBjvdp2RX9Ph1Df1z+3Ku9HTBKWWfNbWChASVw0c/FbCul0iFbGU5 jTGDn3HXVANv+z65Ku//F4svTdRGm2M= X-Authority-Analysis: v=2.4 cv=FoI1OWrq c=1 sm=1 tr=0 ts=6a465d3f cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=wzztfOLjYvU_j_VJg8EA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEzMyBTYWx0ZWRfXw8BBf+L9Y1UN 6bYgd7aNQKy+tIFVGticL34q6YC5mRobYuFRQyqupoWd7g8Ybyxqlef2CgIMbmo2HnneiCRaMVH Gn7JayJ7cvlbjzSBn4OGdtFURIfO4dcZTWN46xAtjOeHGdiXNePHenFZ27uTQbN6yB6Tii2TnL2 ZDkkLPxlBK86bnYhsHeEhM9kI24IHAtLKHAVPmDPHMaisIVG3MT3tQc5xWVrcB9E2N+tDAm4JiD LfB0VTp2RPRVPwKBkf6ZAWjkOYAfe3KaWzFWry2qEYrJFR64h1/Kv89O7NUoVd6QfeoIcqYyupY 5R6GJiEyePOiaGBc431kZ/Y6RI1RroQePoWFjGdIf0FI4PF88cew0/j+DauOpyCsyO4gOj3WhiY AmIq9g2gSLXJ46PJDliM1FDi0wLyV9KCVptIdGclNrb1CZb0F702ylX254ON0ZCYHxwQqB2pjS4 OQrrhRbXIePsukwrZnA== X-Proofpoint-ORIG-GUID: fYSL_H9C1Yy6AqSHgrDjiBqvOutgMeRw X-Proofpoint-GUID: fYSL_H9C1Yy6AqSHgrDjiBqvOutgMeRw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020133 On 7/2/26 2:39 PM, Konrad Dybcio wrote: > On 6/30/26 12:06 PM, Pengyu Luo wrote: >> On Tue, Jun 30, 2026 at 5:52 PM Mukesh Savaliya >> wrote: >>> >>> >>> >>> On 6/29/2026 1:33 PM, Pengyu Luo wrote: >>>> On Mon, Jun 29, 2026 at 1:36 PM Mukesh Savaliya >>>> wrote: >>>>> >>>>> Hi Pengyu, >>>>> >>>>> On 6/15/2026 2:48 AM, Dmitry Baryshkov wrote: >>>>>> On Sun, Jun 14, 2026 at 04:34:24PM +0800, Pengyu Luo wrote: >>>>>>> Some devices (such as gaokun3) do not disable FIFO mode, causing the >>>>>>> driver to fallback to FIFO mode by default. However, these platforms >>>>>>> also support GSI mode, which is highly preferred for certain >>>>>>> peripherals like SPI touchscreens to improve performance. >>>>>>> >>>>>>> Introduce the "qcom,force-gsi-mode" device property to hint and force >>>>>>> the controller into GSI mode during initialization. >>>>> Why to force ? You can directly configure in GSI mode. Note there are >>>>> some configuration done prior to Linux bootup too. >>>> >>>> Sorry, I don't get it. how? I know there may be a qupfw, but it is >>>> impossible for a normal user like me to generate one with GSI >>>> preferred. >>>> >>> If firmware doesn't program in GSI, you can't have this working in GSI >>> mode, its going to fail (and work with fallback). if it's programmed in >>> GSI, anyway this will run in GSI mode. So why to add extra things >>> without any usage ? >>> >> >> What I can confirm is that fifo is not disabled on my device, and gsi >> is definitely enabled (under windows, check the register >> SE_GENI_DMA_MODE_EN), forcing the device to enable GSI mode on linux >> works well. > > What's the value of se->base + SE_DMA_IF_EN (+0x2004) on this SE? I'm sorry, I read the first sentence only.. I think the enabling of DMA and the disabling of FIFO are technically disjoint operations, but shouldn't be. The programming guide mentions that FIFO_DISABLE=1 is set to prevent malicious software from snooping the data from the RX FIFO while the SE is operated through the GSI. Mukesh, would it make sense to make to rework the checks this way: if (dma_enabled) prefer GSI, try SE DMA otherwise else if (fifo_disabled) return error, misconfigured SE else fifo mode ? Konrad