From: Kamil Konieczny <k.konieczny@partner.samsung.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: hash.h: Prevent use of req->digest in ahash update
Date: Wed, 07 Mar 2018 11:22:22 +0100 [thread overview]
Message-ID: <6fbd6e11-8c5c-4935-6f9e-0cea8f5dd178@partner.samsung.com> (raw)
In-Reply-To: <0d5cfbd5-8675-290b-f840-d9121872f8da@amd.com>
On 06.03.2018 19:04, Tom Lendacky wrote:
> On 3/6/2018 5:45 AM, Kamil Konieczny wrote:
>> Prevent improper use of req->digest field in ahash update, init, export and
>
> Shouldn't that be req->result (here and below)?
Yes, it should, I will send version 2 soon,
thank you.
Best regards,
Kamil Konieczny
>> import functions in drivers code. A driver should use ahash request context
>> if it needs to save internal state.
>>
>> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
>> ---
>> include/crypto/hash.h | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/crypto/hash.h b/include/crypto/hash.h
>> index 2d1849dffb80..e97c2e662d6a 100644
>> --- a/include/crypto/hash.h
>> +++ b/include/crypto/hash.h
>> @@ -74,7 +74,8 @@ struct ahash_request {
>> * @init: **[mandatory]** Initialize the transformation context. Intended only to initialize the
>> * state of the HASH transformation at the beginning. This shall fill in
>> * the internal structures used during the entire duration of the whole
>> - * transformation. No data processing happens at this point.
>> + * transformation. No data processing happens at this point. Driver code
>> + * implementation must not use req->digest.
>> * @update: **[mandatory]** Push a chunk of data into the driver for transformation. This
>> * function actually pushes blocks of data from upper layers into the
>> * driver, which then passes those to the hardware as seen fit. This
>> @@ -83,7 +84,8 @@ struct ahash_request {
>> * transformation. This function shall not modify the transformation
>> * context, as this function may be called in parallel with the same
>> * transformation object. Data processing can happen synchronously
>> - * [SHASH] or asynchronously [AHASH] at this point.
>> + * [SHASH] or asynchronously [AHASH] at this point. Driver must not use
>> + * req->digest.
>> * @final: **[mandatory]** Retrieve result from the driver. This function finalizes the
>> * transformation and retrieves the resulting hash from the driver and
>> * pushes it back to upper layers. No data processing happens at this
>> @@ -120,11 +122,12 @@ struct ahash_request {
>> * you want to save partial result of the transformation after
>> * processing certain amount of data and reload this partial result
>> * multiple times later on for multiple re-use. No data processing
>> - * happens at this point.
>> + * happens at this point. Driver must not use req->digest.
>> * @import: Import partial state of the transformation. This function loads the
>> * entire state of the ongoing transformation from a provided block of
>> * data so the transformation can continue from this point onward. No
>> - * data processing happens at this point.
>> + * data processing happens at this point. Driver must not use
>> + * req->digest.
>> * @halg: see struct hash_alg_common
>> */
>> struct ahash_alg {
>>
>
>
>
prev parent reply other threads:[~2018-03-07 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180306114512eucas1p286d36bafa1bc719d7e7ccbaa9f549fc1@eucas1p2.samsung.com>
2018-03-06 11:45 ` Kamil Konieczny
2018-03-06 18:04 ` Tom Lendacky
2018-03-07 10:22 ` Kamil Konieczny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fbd6e11-8c5c-4935-6f9e-0cea8f5dd178@partner.samsung.com \
--to=k.konieczny@partner.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®