From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Peter Rosin <peda@axentia.se>,
Luis Oliveira <Luis.Oliveira@synopsys.com>, <wsa@the-dreams.de>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<jarkko.nikula@linux.intel.com>,
<andriy.shevchenko@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <Ramiro.Oliveira@synopsys.com>, <Joao.Pinto@synopsys.com>,
<CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH v2] i2c: designware: Cleaning and comment style fixes.
Date: Thu, 15 Dec 2016 15:53:07 +0000 [thread overview]
Message-ID: <6fc278a6-dc22-37f8-0868-9f4359cfecf8@synopsys.com> (raw)
In-Reply-To: <f11794ec-439b-5fcd-65f4-c14c319cd627@axentia.se>
On 15-Dec-16 15:17, Peter Rosin wrote:
> On 2016-12-15 15:38, Luis Oliveira wrote:
>> diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
>> index 26250b425e2f..3cb81fca7738 100644
>> --- a/drivers/i2c/busses/i2c-designware-core.h
>> +++ b/drivers/i2c/busses/i2c-designware-core.h
>> @@ -36,7 +36,7 @@
>> #define DW_IC_CON_SPEED_FAST 0x4
>> #define DW_IC_CON_SPEED_HIGH 0x6
>> #define DW_IC_CON_SPEED_MASK 0x6
>> -#define DW_IC_CON_10BITADDR_MASTER 0x10
>> +#define DW_IC_CON_10BITADDR_MASTER 0x10
>
> How is this an improvement?
It is not, I will fix it.
Thanks,
Luis
>
> Cheers,
> peda
>
prev parent reply other threads:[~2016-12-15 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 14:38 Luis Oliveira
2016-12-15 14:56 ` Andy Shevchenko
2016-12-15 15:17 ` Peter Rosin
2016-12-15 15:53 ` Luis Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fc278a6-dc22-37f8-0868-9f4359cfecf8@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®