mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Barto <mister.freeman@laposte.net>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, mchehab@osg.samsung.com
Subject: [PATCH 4.5 1/1] revert commit 2c1f6951a8 videobuf2-v4l2
Date: Thu, 12 May 2016 23:47:37 +0200	[thread overview]
Message-ID: <6fcbf0e7-7c19-3574-9a8a-dc204195bfa1@laposte.net> (raw)

since kernel 4.5.3 a severe bug has been introduced with commit
2c1f6951a8a82e6de0d82b1158b5e493fc6c54ab ( [media] videobuf2-v4l2:
Verify planes array in buffer dequeueing ),

a system freeze will occur with TV cards ( DVB-T ), for example with
"leadtek winfast DTV1000T", "leadtek winfast DTV1800H", "Avermedia" and
many others,

https://bugzilla.kernel.org/show_bug.cgi?id=118061

one quick fix is to revert this commit

--- a/drivers/media/v4l2-core/videobuf2-v4l2.c    2016-05-12
06:14:24.000000000 +0200
+++ b/drivers/media/v4l2-core/videobuf2-v4l2.c    2016-05-12
06:21:16.773477390 +0200
@@ -74,10 +74,6 @@
     return 0;
 }
 
-static int __verify_planes_array_core(struct vb2_buffer *vb, const void
*pb)
-{
-    return __verify_planes_array(vb, pb);
-}
 
 /**
  * __verify_length() - Verify that the bytesused value for each plane
fits in
@@ -442,7 +438,6 @@
 }
 
 static const struct vb2_buf_ops v4l2_buf_ops = {
-    .verify_planes_array    = __verify_planes_array_core,
     .fill_user_buffer    = __fill_v4l2_buffer,
     .fill_vb2_buffer    = __fill_vb2_buffer,
     .copy_timestamp        = __copy_timestamp,

                 reply	other threads:[~2016-05-12 21:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fcbf0e7-7c19-3574-9a8a-dc204195bfa1@laposte.net \
    --to=mister.freeman@laposte.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®