Re: [PATCH v2 1/2] cpufreq: Preserve global boost state on failed updates

[Sumit Gupta <sumitg@nvidia.com>]

On 05/11/26 14:33, Christian Loehle wrote:
> External email: Use caution opening links or attachments
> 
> 
> cpufreq_boost_trigger_state() restores the opposite of the requested
> state when updating policy boost state fails. For example, a failed
> write of 0 when global boost is already disabled enables the global
> flag without enabling any policies.
> 
> Save the original global boost state and restore it on failure.
> 
> Fixes: 121baab7b88e ("cpufreq: Force sync policy boost with global boost on sysfs update")
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
> Reviewed-by: Pengjie Zhang <zhangpengjie2@huawei.com>
> ---

Reviewed-by: Sumit Gupta <sumitg@nvidia.com>


>   drivers/cpufreq/cpufreq.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 54dde8419bdc..23a77f5524df 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2814,6 +2814,7 @@ static int cpufreq_boost_trigger_state(int state)
>   {
>          struct cpufreq_policy *policy;
>          unsigned long flags;
> +       bool boost_enabled;
>          int ret = -EOPNOTSUPP;
> 
>          /*
> @@ -2822,6 +2823,7 @@ static int cpufreq_boost_trigger_state(int state)
>           */
> 
>          write_lock_irqsave(&cpufreq_driver_lock, flags);
> +       boost_enabled = cpufreq_driver->boost_enabled;
>          cpufreq_driver->boost_enabled = state;
>          write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> 
> @@ -2841,7 +2843,7 @@ static int cpufreq_boost_trigger_state(int state)
>                  return 0;
> 
>          write_lock_irqsave(&cpufreq_driver_lock, flags);
> -       cpufreq_driver->boost_enabled = !state;
> +       cpufreq_driver->boost_enabled = boost_enabled;
>          write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> 
>          pr_err("%s: Cannot %s BOOST\n",
> --
> 2.34.1
>