mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Vítor Hugo Silva" <vitorhg20080@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (ads7871) Add error handle from spi_setup()
Date: Tue, 17 Nov 2026 15:15:50 -0800	[thread overview]
Message-ID: <6fcf276b-8e06-45aa-a780-f91bcf478d8f@roeck-us.net> (raw)
In-Reply-To: <20261117205132.141964-1-vitorhg20080@gmail.com>

On 11/17/26 12:51, Vítor Hugo Silva wrote:
> The ads7871 probe() ignores the spi_setup() error return value
> and it attempts to write on registers even if spi_setup() fails or not
> 
or not what ?

> This patch returns the setup error before accessing any registers.
> 
s/This patch returns/Return/

(imperative mood, see Documentation/process/submitting-patches.rst)

Thanks,
Guenter

> AI was used for peer-review the patch.
> 
> Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
> 
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
> ---
>   drivers/hwmon/ads7871.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> index 36297bc6d047..a1ffc35d9272 100644
> --- a/drivers/hwmon/ads7871.c
> +++ b/drivers/hwmon/ads7871.c
> @@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
>   	/* Configure the SPI bus */
>   	spi->mode = (SPI_MODE_0);
>   	spi->bits_per_word = 8;
> -	spi_setup(spi);
> +	ret = spi_setup(spi);
> +	if (ret)
> +		return ret;
>   
>   	pdata = devm_kzalloc_obj(dev, *pdata);
>   	if (!pdata)


      reply	other threads:[~2026-11-17 23:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:51 Vítor Hugo Silva
2026-11-17 23:15 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fcf276b-8e06-45aa-a780-f91bcf478d8f@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vitorhg20080@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®