From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6714E198A17 for ; Fri, 17 Apr 2026 12:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776427443; cv=none; b=DW9OPVk+cZe14BJXN23Tm5HpI52PCSf7HABR1JRWwn4Iwo3hbTgP9nBdcwt8188GS/pvKg5C9BXXhpbs5oFjiak2z1j+XlD+ier/LCyW4TfMENJ4H4H0w/bVJ5fKI1yCJ2pzKD9KDKo+0Upm7RAq0kWE5FhfaTGFzyw+Rl687tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776427443; c=relaxed/simple; bh=XRnNIrcsMnEVq95YKOZf7K6BMN+ywiHLZr9nGpX1sd0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=sndNlofqrub7mL38f0CHHOCkHoYyHEoA6+0ybiXtA/bMot2hrQi8XUHAb5rQxcRNzzKNFwJbksdywdmkOFm9U1ZXC2k+hsI7peMH4U5X/mFvOIeq31bUUNWfar4hqqW6VgnS3uAqatiJOZ3xflVWk7A5jLUbYo3fU0og2k2ntd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BaaqjmI0; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BaaqjmI0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776427441; x=1807963441; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=XRnNIrcsMnEVq95YKOZf7K6BMN+ywiHLZr9nGpX1sd0=; b=BaaqjmI0uRUCWW1g/Vsaj7c/nlHlqs1tW/UwAAHMso3yq/a6ibxwHZQx 01MSAz19P+PAB/Mfjp2X1Xf4ehdNYpyIg699e39ahHIhGQFMaaI931D93 oII89XQggNA0Ar5neHuoFSnVg3MM5oq50Bva7oPDH873RK3kVTWi+8eIC BZMlTL9kGxjiIdOMJO0xiC+Fd9DHoJlHq7fwUf7nZZhROYfZequH1pmup 9Q/19vJHB8JhuDTIaYyD36ijMZ1bXyF6kRNw8KPqQUac6mD0vHKGPgCZx slSDkkViq7AqI8RAhbuINUSyoAo5IpRHsv3fIsmpiPpcAyvSERd0RLGj9 A==; X-CSE-ConnectionGUID: wuN0hM/GQhiWJFYydQSfmQ== X-CSE-MsgGUID: f8Jv15q1SqSPOmx3DuEMug== X-IronPort-AV: E=McAfee;i="6800,10657,11761"; a="80029836" X-IronPort-AV: E=Sophos;i="6.23,184,1770624000"; d="scan'208";a="80029836" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2026 05:04:00 -0700 X-CSE-ConnectionGUID: 02vpZtdORFu3FDE4eA8c8g== X-CSE-MsgGUID: X6eHqJniQ0qtpFQZ8odHfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,184,1770624000"; d="scan'208";a="235399324" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.245.127]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2026 05:03:57 -0700 From: Jani Nikula To: sai madhu , Chun-Kuang Hu Cc: Philipp Zabel , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sai madhu Subject: Re: [PATCH] drm/mediatek: hdmi: Convert DRM_ERROR() to drm_err() In-Reply-To: <20260417113310.2903091-1-suryasaimadhu369@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260417113310.2903091-1-suryasaimadhu369@gmail.com> Date: Fri, 17 Apr 2026 15:03:54 +0300 Message-ID: <6fd252e6c41a1a6a0b57fb381d33f2e0813b5b14@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, 17 Apr 2026, sai madhu wrote: > The DRM_ERROR() macro is deprecated in favor of drm_err() which > provides device-specific logging. > > Replace DRM_ERROR() with drm_err() in the Mediatek HDMI bridge > driver and pass the drm_device pointer via bridge->dev. > > No functional change intended. > > Signed-off-by: sai madhu > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 1ea259854780..f431fc9adca5 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -981,8 +981,9 @@ static int mtk_hdmi_bridge_attach(struct drm_bridge *bridge, > int ret; > > if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { > - DRM_ERROR("%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n", > - __func__); > + drm_err(bridge->dev, > + "%s: The flag DRM_BRIDGE_ATTACH_NO_CONNECTOR must be supplied\n", > + __func__); We really shouldn't be logging __func__ either. Errors should be unambigious anyway, and drm_dbg* logging uses __builtin_return_address(0) to achieve the same with a much smaller footprint. BR, Jani. > return -EINVAL; > } -- Jani Nikula, Intel