From: "Karoly Pados" <pados@pados.hu>
To: "Johan Hovold" <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Loic Poulain" <loic.poulain@linaro.org>
Subject: Re: [PATCH v6] USB: serial: ftdi_sio: implement GPIO support for FT-X devices
Date: Tue, 25 Sep 2018 11:11:03 +0000 [thread overview]
Message-ID: <6fdea2db02ece8c7b51fb03a112fa4c0@pados.hu> (raw)
In-Reply-To: <20180925110021.GE3332@localhost>
>> + if (priv->gpio_output & BIT(gpio))
>> + return 0;
>> + else
>> + return 1;
>>
>> This could just simplified using negation (!), but perhaps this is
>> easier to parse as it stands.
>>
>> Sorry, it is not clear what your preferred action here is.
>> So should I leave it as is then or not?
>
> Just do
>
> res = !(priv->gpio_output & BIT(gpio));
>
Locking here? priv->gpio_output is a u8, there is no way it can be partially
written. Or am I missing something else?
Karoly
next prev parent reply other threads:[~2018-09-25 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 14:31 Karoly Pados
2018-09-25 10:06 ` Johan Hovold
2018-09-25 10:15 ` Johan Hovold
2018-09-25 10:47 ` Karoly Pados
2018-09-25 10:46 ` Karoly Pados
2018-09-25 11:00 ` Johan Hovold
2018-09-25 11:11 ` Karoly Pados [this message]
2018-09-25 12:08 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fdea2db02ece8c7b51fb03a112fa4c0@pados.hu \
--to=pados@pados.hu \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®