From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADCFC6FA86 for ; Tue, 27 Sep 2022 09:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbiI0J27 (ORCPT ); Tue, 27 Sep 2022 05:28:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbiI0J2h (ORCPT ); Tue, 27 Sep 2022 05:28:37 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5057EAC254 for ; Tue, 27 Sep 2022 02:28:35 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id s14so14129016wro.0 for ; Tue, 27 Sep 2022 02:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date; bh=3X71jgPXg+1alqFPpU+/3mDimmf52ETp0ZJlAFk/E/o=; b=z6KgShAv0W1DLcY21kMpPukJgMWCcit/PbW4j6VHqp/qWPb+h5E343lQva1WuYrac2 phVMC3GXswSvrpWz9+wv9VpgN2954EShNpTAtzbANmXn6KVfbIo18gR+AqgyUbc2RIZW bfn06/ibQ/J7VKYWCuPLT6+nrSdrifxWymf0QQnzK9igyRdFvcIiMvTHQGNfwp6RZOlW J321TvZPI0BKX0yxuNjZnMzkTuwT1/bpoN9F9jt1toro8Y7sJ181X94TyleVounyy/E7 UEaqg85sNuRosNWfDdDp2dQmix+3JDgU9tdf0AMhWk9B9Vv54Lk1cC7gltyjjdIisUNi AwAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=3X71jgPXg+1alqFPpU+/3mDimmf52ETp0ZJlAFk/E/o=; b=odHvoMWeHhU+IsXzfAHO6PJttLKoc0BZN8gIdJg8s0054boQGPUeJOYB4nG/WChbVd M6fXyA0qkmyw43B4K8DOS6B/LWG/bbNw8xOCYhZxzLVHxmeI0S6dj9akLIVdsQLfGZFl 7CkfKraqg4p3UToPIu546zIHtd1suqmqXP2p27FGiaQtMACsCfcD2nwSX3cfI6PLPdWT jYpa8MYqQuq2H0oPQp07IU8WXNmYD1Pm1CCzcoYkUFt9UMI8xoqv+h6Ry2tVklStHjmd BCme1A22CKLMT3HMTmhxHQEpLYEOYW36JcCJXk1+v9pWn9qkVPHaKlieJa3qVQlMSzwb qdEQ== X-Gm-Message-State: ACrzQf0eFKpXeZoLckLwaqPr6RrKr4PVNC01jub7CpL/MGGojQiqgXC0 SEJ3uCFEPvo13cqGnW+8FzT379S+bm3E5C9K X-Google-Smtp-Source: AMsMyM4W0H079weu2O9TWS4Qz8MrGzq0EJNtemPEv5s8UWQrTYaDAo6b7Bn36YZ4qCZAO8MIjyA4kw== X-Received: by 2002:a5d:5944:0:b0:22a:c2d1:e3fe with SMTP id e4-20020a5d5944000000b0022ac2d1e3femr15788612wri.261.1664270913882; Tue, 27 Sep 2022 02:28:33 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:b771:c77b:f889:9833? ([2a01:e0a:982:cbb0:b771:c77b:f889:9833]) by smtp.gmail.com with ESMTPSA id e18-20020adffd12000000b0022878c0cc5esm1246484wrr.69.2022.09.27.02.28.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 02:28:33 -0700 (PDT) Message-ID: <6fe2be1b-faaf-86cd-8fcc-a919d30d65c6@linaro.org> Date: Tue, 27 Sep 2022 11:28:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v8 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Content-Language: en-US To: Jiucheng Xu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Will Deacon , Mark Rutland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chris Healy , Jianxin Pan , Kelvin Zhang References: <20220916020320.2455580-1-jiucheng.xu@amlogic.com> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20220916020320.2455580-1-jiucheng.xu@amlogic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, Mark, On 16/09/2022 04:03, Jiucheng Xu wrote: > This patch adds support Amlogic meson G12 series SoC > DDR bandwidth PMU driver framework and interfaces. > > The PMU not only can monitor the total DDR bandwidth, > but also the bandwidth which is from individual IP module. > > Example usage: > > $ perf stat -a -e meson_ddr_bw/total_rw_bytes/ -I 1000 sleep 10 > > - or - > > $ perf stat -a -e \ > meson_ddr_bw/total_rw_bytes/,\ > meson_ddr_bw/chan_1_rw_bytes,arm=1/ -I 1000 \ > sleep 10 > > g12 SoC support 4 channels to monitor DDR bandwidth > simultaneously. Each channel can monitor up to 4 IP modules > simultaneously. > > For Instance, If you want to get the sum of DDR bandwidth > from CPU, GPU, USB3.0 and VDEC. You can use the following > command parameters to display. > > $ perf stat -a -e \ > meson_ddr_bw/chan_2_rw_bytes,arm=1,gpu=1,usb3_0=1,nna=1/ -I 1000 \ > sleep 10 > > Other events are supported, and advertised via perf list. > > Signed-off-by: Jiucheng Xu > --- > Changes v7 -> v8: > - Add linux-amlogic@lists.infradead.org maillist for MAINTAINERS > - Change driver name from "amlogic,g12-ddr-pmu" to "meson-g12-ddr-pmu" > > Changes v6 -> v7: > - Drop the Reported-by tag > > Changes v5 -> v6: > - Add const for driver data > > Changes v4 -> v5: > - Remove error message > - Use smp_processor_id() instead of raw_smp_processor_id() > - Remove EXPORT_SYMBOL() > - Use variant specific driver data for compatible > - Use module_platform_driver for modules_init/exit > - Change location of driver structures from .h to .c > > Changes v3 -> v4: > - No change > > Changes v2 -> v3: > - Fix sh GCC 12.1.0 compiling warning > - Rename prefix aml to meson for files and code > > Changes v1 -> v2: > - Remove inline to let GCC make the decisions > - Remove spinlock > - Remove ddr_cnt_accumulate() > - Remove the message which only indicate a bug > - Remove all dev_warn() message > - Use hweight64() helper instead of whole loop > - Remove setting of hwc > - Use for_each_set_bit() helper for bit loop > - Use sysfs_emit() in sysfs show > - Remove checking for bugs > - Replace irq_set_affinity_hint() to irq_set_affinity() > - Remove #ifdef CONFIG_OF > - Use devm_platform_ioremap_resource() instead of > platform_get_resource()&ioremap() > - Use platform_get_irq() instead of platform_get_resource()&ioremap() > - Replace IRQF_SHARED to IRQF_NOBALANCING > - Remove meaningless log like "init ok" > - Use compatible instead of creating new property to distinguish > different platform. > - Use the is_visible callback to avoid exposing unsupported fmt_attr > - Use module_platform_driver_probe() instead of module_init/exit Gentle ping, it seems all previous review comments were addressed, could you do another review round on this v8 ? Thanks, Neil