From: Judith Mendez <jm@ti.com>
To: Andrew Davis <afd@ti.com>, <devicetree@vger.kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Hari Nagalla <hnagalla@ti.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 1/9] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node
Date: Mon, 3 Feb 2025 16:12:35 -0600 [thread overview]
Message-ID: <6fe74c50-1430-4556-90b5-f635fb48e6fb@ti.com> (raw)
In-Reply-To: <1c2c67b7-987e-4b92-b0be-c0b2f25adae6@ti.com>
Hi Andrew,
On 1/31/25 5:40 PM, Andrew Davis wrote:
> On 1/31/25 3:46 PM, Judith Mendez wrote:
>> From: Hari Nagalla <hnagalla@ti.com>
>>
>
> Subject should capitalize R5F
Will fix in v3, thanks
>
>> AM62 SoC devices have a single core R5F processor in wakeup domain.
>> The R5F processor in wakeup domain is used as a device manager
>> for the SoC.
>>
>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
>> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>> Changes since v1:
>> - disable each device node in the voltage domain files and
>> enable at the board level file
>> - fix firmware names
>> ---
>> arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 25 ++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> index 9b8a1f85aa15c..12b1520974ade 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
>> @@ -106,6 +106,31 @@ wkup_rti0: watchdog@2b000000 {
>> status = "reserved";
>> };
>> + wkup_r5fss0: r5fss@78000000 {
>> + compatible = "ti,am62-r5fss";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x78000000 0x00 0x78000000 0x8000>,
>> + <0x78100000 0x00 0x78100000 0x8000>;
>
> Odd alignment, looks like you have an extra tab on the above line
Hmm missed this, thanks will fix.
~ Judith
>
> Andrew
>
>> + power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
>> + status = "disabled";
>> +
>> + wkup_r5fss0_core0: r5f@78000000 {
>> + compatible = "ti,am62-r5f";
>> + reg = <0x78000000 0x00008000>,
>> + <0x78100000 0x00008000>;
>> + reg-names = "atcm", "btcm";
>> + ti,sci = <&dmsc>;
>> + ti,sci-dev-id = <121>;
>> + ti,sci-proc-ids = <0x01 0xff>;
>> + resets = <&k3_reset 121 1>;
>> + firmware-name = "am62-wkup-r5f0_0-fw";
>> + ti,atcm-enable = <1>;
>> + ti,btcm-enable = <1>;
>> + ti,loczrama = <1>;
>> + };
>> + };
>> +
>> wkup_vtm0: temperature-sensor@b00000 {
>> compatible = "ti,j7200-vtm";
>> reg = <0x00 0xb00000 0x00 0x400>,
next prev parent reply other threads:[~2025-02-03 22:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 21:46 [PATCH v2 0/9] Add R5F and C7xv device nodes Judith Mendez
2025-01-31 21:46 ` [PATCH v2 1/9] arm64: dts: ti: k3-am62-wakeup: Add wakeup r5f node Judith Mendez
2025-01-31 23:40 ` Andrew Davis
2025-02-03 22:12 ` Judith Mendez [this message]
2025-01-31 21:46 ` [PATCH v2 2/9] arm64: dts: ti: k3-am62a-mcu: Add R5F remote proc node Judith Mendez
2025-01-31 21:46 ` [PATCH v2 3/9] arm64: dts: ti: k3-am62a-wakeup: Add R5F device node Judith Mendez
2025-01-31 21:46 ` [PATCH v2 4/9] arm64: dts: ti: k3-am62a-main: Add C7xv " Judith Mendez
2025-01-31 21:46 ` [PATCH v2 5/9] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote processors Judith Mendez
2025-02-03 22:53 ` Andrew Davis
2025-02-03 23:06 ` Judith Mendez
2025-01-31 21:46 ` [PATCH v2 6/9] arm64: dts: ti: k3-am62p5-sk: " Judith Mendez
2025-01-31 21:46 ` [PATCH v2 7/9] arm64: dts: ti: k3-am62x-sk-common: " Judith Mendez
2025-01-31 21:46 ` [PATCH v2 8/9] arm64: dts: ti: k3-am62a7-sk: Reserve main_timer2 for C7x DSP Judith Mendez
2025-01-31 21:46 ` [PATCH v2 9/9] arm64: dts: ti: k3-am62a7-sk: Reserve main_rti4 " Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fe74c50-1430-4556-90b5-f635fb48e6fb@ti.com \
--to=jm@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®