From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72959299A8F for ; Fri, 13 Mar 2026 12:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403818; cv=none; b=QqwrpYqmw919RhSJOM89aiCi4zLRiF4pPq9sCuXWN1NuirorgvuoLgMap34wgyP0ULsMGY7ciglPsDGUTThWq+3MEvDaUPX127jQXf/6/r107eQ56dGpUu1dSXXh9Y3YWsjthvCU+uF5yF926ZWk4GJpVO6oBfPHWrdhOEEi1cs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773403818; c=relaxed/simple; bh=3j40h47Hn4awqL9qP/MPQoHK6+d8901Kvhjnk0RZ0xE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uJbfklSMcZ52XIApT3B0a9CvtYjn+QczCwy5ugpd29WpGWFS6YDzBoBeQcZ1NaCj/7iMG6lN0nNTOwYPKHKfO6Evp689eAKzLl3iM45ekkCqH0R/icK2Mbjky49vRzNzle17Pny2P/nVtGxLxMnoym26t95OP/ltS+2rqDeiPU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fSAg5Vni; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NLkpz0ju; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fSAg5Vni"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NLkpz0ju" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DAmped2390204 for ; Fri, 13 Mar 2026 12:10:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uCbudEYrsbIZxOttkpxzt84Ar9N49Wo0ZjpsYXWJucg=; b=fSAg5Vnie86E6/5+ G7DimziqQ38PzF8DUYX2G7XRjsqEo8MGBsbEuwRa8sjX/ND/j1TUVMHyhftGQAs1 5ur5k9ywJEgGjL3I5GByOvpGFuZzHkqTT7ERsQGySg/Mkxglw/VVFqNZd+IPY7yU S035NbeSCpbfw+ZreOaGu8doio2lIqPJvfskt+yYXKONkruxrWWIV+YoklKjDFLa SV3r4JUAch5bUjHyZ8AyocCPMT2NU8WlbVaOfvedcwS041h0fly7b49n+VNhF9cG XlSkKLuclW5oZLVSjm40cz5ngZ2o6s+2R17UMiJ5ig6V4zS2t9K+G2+CsMPKRwXD flr+jg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvh5m872n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 12:10:16 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89a081737bbso19523566d6.2 for ; Fri, 13 Mar 2026 05:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773403816; x=1774008616; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uCbudEYrsbIZxOttkpxzt84Ar9N49Wo0ZjpsYXWJucg=; b=NLkpz0juqMLcuIE52tKsNtcULva+FNb2xYem3nR35bR1KU09NZgBBiLmdjaT+MDJWt vwJYLdPAGkwf8Mw6Vtk50TJTs/TAH2EYKnS+b3Eps4YLKFZhkocaQUOcDs1TRfVPvJCJ 3Ilf1BVWmijSYxAeFMXEeJcDoVUeDewsXnhv6K6x/QSUqphat7ZCjtSvORy7IW7wh7ic BTj0W0ruy1iGyPoaXUtoZq4focY/m0GcjejBiEX4wvgr/0LRGm5mdCxdxq0ZU38ZueQF 1ZCcfjsDc115Tg2yhcJI/38eibyX2HVYrQ4GL9+xXLilCNKPAKbRdrLz3ew9qJnGnYue 4kvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773403816; x=1774008616; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uCbudEYrsbIZxOttkpxzt84Ar9N49Wo0ZjpsYXWJucg=; b=hZVoAaCNJ3c+hF9Q9TOGKwjvh8+ecRa5QYTZZ3LFLtb5AzQiuAh3ff+Yr8Y+iEcG7d SBIkZhg9BxDBSAhu8obF0dx5fug6nzxqTDuUMOPskulKApGobgPNmwDDCMpEdZui8hUC XCWJ1XfhTlWfvuEGJGcXHK0620l7hLwubj6lJFPWuQsKT6aLfmNH+T2O9St0JaC2KjeC /bxFg8v6397NSUvgf4c054ORmALgYrNvMBuWPdGml82VJlN7bbK9CaDRa+cAr48q++Wu SAxkmBP4Z+kP0UGJjf6KQ6EhQiWSbuxME9dveJY6IZPl8RhKMjW3pMG6CW/IzT1nE6cI ks3w== X-Forwarded-Encrypted: i=1; AJvYcCXBWaAUZF2ebh5+9is/iVBKzvBgfnIC+GFnKKoZr9ccF+LMI14ayUOaHjTjlawLO3o/DRlbJZfJQRLd+mw=@vger.kernel.org X-Gm-Message-State: AOJu0YwMItN0rN8wGq4O+XUHGjF+7ASDL58nXLOosTJC/3NBRkNclIwF Zeu2HVh0wtfmn12QfyzGdpwDxI6YgUX38OKWY1ZxIxpL+FEiFBD6SF9f6KLQN3LZaEhnbrWyjJr cu8PnnfnvIMgSidV1gXg7Cafp89HZ7AXQO5zqxDloE/lUgrfA0TxSc9QVclyvl8AfOpw= X-Gm-Gg: ATEYQzxFZHjxaCy37agfXRQuJz5O6mWxRgWorx1zQ8+z01jGUq0dVkqf8lKf7Jau7/R 47HOORxn798oO/Rg2j+jFPal+A1cmWffCJH6dYhmXMJnNDD2JteEA8fqbpdjaB/65yzM8IEIkUz SYKATeHHzCn5sUQxKlZA8N92IKesaaoc58XQhk8zCjmCl3T6nzVWkRSjHtyKs7EmBgFbOZM1byK FLZGLSRgMLHDwUw69Eyi9+37Q6IB2dRZGffFBv2Cuns1WRVQzWds5wWYTJWpKSAww2U2VE+xkZ9 wIZYfToDdNDx5Vw4Ko5KjEyUBeqFPiNquAIj2WVyPJJVMqUeVOb0eRrFrhjrqb6tmFs2qpbj3hr seWwMh+tiAjtuW4QNxzmn+SBvxbdLfDa+LucoS3USMr6Zc6/4/46DfSaspkXN9ow7FZ8+Ef8z8N H4wLg= X-Received: by 2002:ac8:58c3:0:b0:509:2b5a:808 with SMTP id d75a77b69052e-50957ca0451mr31971651cf.2.1773403815876; Fri, 13 Mar 2026 05:10:15 -0700 (PDT) X-Received: by 2002:ac8:58c3:0:b0:509:2b5a:808 with SMTP id d75a77b69052e-50957ca0451mr31970991cf.2.1773403815156; Fri, 13 Mar 2026 05:10:15 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6634fdc8932sm1190869a12.14.2026.03.13.05.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 05:10:13 -0700 (PDT) Message-ID: <6fe7a63c-a1b3-430b-a128-0e38754d6393@oss.qualcomm.com> Date: Fri, 13 Mar 2026 13:10:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 02/10] usb: misc: qcom_eud: add sysfs attribute for port selection To: Greg Kroah-Hartman , Elson Serrao Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309203337.803986-1-elson.serrao@oss.qualcomm.com> <20260309203337.803986-3-elson.serrao@oss.qualcomm.com> <2026031101-cornstalk-partner-a30e@gregkh> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2026031101-cornstalk-partner-a30e@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: FjYkMD6-VmyJq7QjW5Em1fi9jlSxsGy3 X-Proofpoint-GUID: FjYkMD6-VmyJq7QjW5Em1fi9jlSxsGy3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5NiBTYWx0ZWRfX2k7iB/xqJnjD d5+8KSpRRtRt25T2OC9q4N0fOu7pdkh3ZXqfQXC9ASag96cH0+2DlnkEE+h1L0MT8hSosl17kO9 AfelVfP9pjk44yJs4rA93q81u1Cq8zcCb3Ptj5JGfCgSEQXm/YnFw3xWKMFSh/DXHJ1utrDhHpf KFPcScvSMD0oKdiT8uUEHoCk3FbQBCSIxq+xL+ZAHpKMu5m0o5sinHL8gEfTMRcF9+mcc1w7auT +lHWm0QAHySQfsbQOZ2pGsZUXyoEm2/Ko/wxsOeLy5/s4sWH7ur8VFgKm2PZSLLu1mQSOq5lTJ0 oxfmTdtJT2IAybRhsWwK3kxurceNeUgpZp1rGRbQIs4D86ex+Lyfl8UtPqhTd70M5bXmcUgL/b3 JgjyijghvO1C+zRDfpfAxjwGx1W0N/ELnISz1DXgYb/3fkOz8wGGEswAriZAc6iCdgcVeCmNPFZ BlQxds4w0rfXW9WlZ7Q== X-Authority-Analysis: v=2.4 cv=S6TUAYsP c=1 sm=1 tr=0 ts=69b3fea8 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=ZSumbHMXNyApqtGpG_AA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130096 On 3/11/26 2:16 PM, Greg Kroah-Hartman wrote: > On Mon, Mar 09, 2026 at 01:33:29PM -0700, Elson Serrao wrote: >> EUD can be mapped to either the primary USB port or the secondary USB port >> depending on the value of the EUD_PORT_SEL register. Add a 'port' sysfs >> attribute to allow userspace to select which port EUD should operate on >> and update the ABI documentation. This is needed for systems with dual >> USB ports where EUD needs to be accessible on either port depending on the >> system configuration and use case. >> >> Signed-off-by: Elson Serrao >> --- >> Documentation/ABI/testing/sysfs-driver-eud | 16 ++++++++ >> drivers/usb/misc/qcom_eud.c | 43 ++++++++++++++++++++++ >> 2 files changed, 59 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-driver-eud b/Documentation/ABI/testing/sysfs-driver-eud >> index 2bab0db2d2f0..67223f73ee60 100644 >> --- a/Documentation/ABI/testing/sysfs-driver-eud >> +++ b/Documentation/ABI/testing/sysfs-driver-eud >> @@ -7,3 +7,19 @@ Description: >> EUD based on a 1 or a 0 value. By enabling EUD, >> the user is able to activate the mini-usb hub of >> EUD for debug and trace capabilities. >> + >> +What: /sys/bus/platform/drivers/qcom_eud/.../port >> +Date: January 2026 >> +Contact: Elson Serrao >> +Description: >> + Selects which USB port the Embedded USB Debugger (EUD) >> + is mapped to on platforms providing multiple High-Speed >> + USB ports. >> + >> + Valid values: >> + 0 - Primary USB port >> + 1 - Secondary USB port > > Why not use "primary" and "secondary" as values instead? That makes > this much simpler to understand. It's not inconceivable that future iterations of this hardware will let one mux between more than two USB PHYs/ports (there are already a multitude of SoCs where we have 4 or more USB controllers and >= that ports) Konrad