From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010D4C19F2A for ; Thu, 4 Aug 2022 15:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231472AbiHDPBf (ORCPT ); Thu, 4 Aug 2022 11:01:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234497AbiHDPBd (ORCPT ); Thu, 4 Aug 2022 11:01:33 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C9F11F2EE; Thu, 4 Aug 2022 08:01:31 -0700 (PDT) Received: from [172.18.172.87] (unknown [46.183.103.8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 0544D61EA1928; Thu, 4 Aug 2022 17:01:21 +0200 (CEST) Message-ID: <6fef92f3-6932-5c20-57fe-9eb40d676013@molgen.mpg.de> Date: Thu, 4 Aug 2022 17:01:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible To: Tomer Maimon Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, jic23@kernel.org, minyard@acm.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20220804145516.217482-1-tmaimon77@gmail.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20220804145516.217482-1-tmaimon77@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Tomer, Am 04.08.22 um 16:55 schrieb Tomer Maimon: > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible > string. > > Signed-off-by: Tomer Maimon > --- > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > index cbc10a68ddef..4fda76e63396 100644 > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt > @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host. > Required properties: > - compatible : should be one of > "nuvoton,npcm750-kcs-bmc" > - "nuvoton,npcm845-kcs-bmc" > + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc" Isn’t the added string exactly the same as the one below the compatible line? > - interrupts : interrupt generated by the controller > - kcs_chan : The KCS channel number in the controller Kind regards, Paul