From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, idosch@mellanox.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
bridge@lists.linux-foundation.org, jiri@mellanox.com,
andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
Date: Tue, 12 Feb 2019 09:54:24 -0800 [thread overview]
Message-ID: <6ff1b9c2-1206-f568-8556-28efe852dd08@gmail.com> (raw)
In-Reply-To: <20190212.095030.1445077555795164973.davem@davemloft.net>
On 2/12/19 9:50 AM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Mon, 11 Feb 2019 13:17:46 -0800
>
>> AFAICT there is no code that attempts to get the value of the attribute
>> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
>> switchdev_port_attr_set().
>>
>> This is effectively no doing anything and it can slow down future work
>> that tries to make modifications in these areas so remove that.
>
> Series applied.
>
>> David, there should be no dependency with previous patch series, but
>> again, feedback from Ido and Jiri would be welcome in case this was
>> added for a reason.
>
> Ok, is there going to be another respin of that switchdev_ops removal
> series?
Yes, I will be working on a v5 which addresses Ido's feedback in the
next hours.
--
Florian
next prev parent reply other threads:[~2019-02-12 17:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 21:17 Florian Fainelli
2019-02-11 21:17 ` [PATCH net-next 1/3] mlxsw: spectrum_switchdev: Remove getting PORT_BRIDGE_FLAGS Florian Fainelli
2019-02-12 8:55 ` Jiri Pirko
2019-02-12 12:18 ` Ido Schimmel
2019-02-11 21:17 ` [PATCH net-next 2/3] rocker: " Florian Fainelli
2019-02-12 8:56 ` Jiri Pirko
2019-02-11 21:17 ` [PATCH net-next 3/3] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-12 7:28 ` Greg KH
2019-02-12 8:56 ` Jiri Pirko
2019-02-12 8:55 ` [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS Jiri Pirko
2019-02-12 17:50 ` David Miller
2019-02-12 17:54 ` Florian Fainelli [this message]
2019-02-12 21:35 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ff1b9c2-1206-f568-8556-28efe852dd08@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®