From: Hans de Goede <hdegoede@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] x86/cpu: Avoid writing MSR_IA32_TSX_CTRL when writing it is not supported
Date: Tue, 6 Sep 2022 22:56:47 +0200 [thread overview]
Message-ID: <6ff23930-325b-4207-12fc-4d8fd5bea1ff@redhat.com> (raw)
In-Reply-To: <YxexAl+i+6MGjf7K@hirez.programming.kicks-ass.net>
Hi,
On 9/6/22 22:43, Peter Zijlstra wrote:
> On Tue, Sep 06, 2022 at 10:17:43PM +0200, Hans de Goede wrote:
>> On an Intel Atom N2600 (and presumable other Cedar Trail models)
>> MSR_IA32_TSX_CTRL can be read, causing saved_msr.valid to be set for it
>> by msr_build_context().
>>
>> This causes restore_processor_state() to try and restore it, but writing
>> this MSR is not allowed on the Intel Atom N2600 leading to:
>
> FWIW, virt tends to do this same thing a lot. They'll allow reading
> random MSRs and only fail on write.
Right. So I guess I should send a v2 with an updated commit
message mentioning this ?
Regards,
Hans
next prev parent reply other threads:[~2022-09-06 20:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 20:17 Hans de Goede
2022-09-06 20:43 ` Peter Zijlstra
2022-09-06 20:56 ` Hans de Goede [this message]
2022-09-06 21:00 ` Peter Zijlstra
2022-09-06 23:00 ` Andrew Cooper
2022-09-07 7:32 ` Hans de Goede
2022-09-08 13:34 ` Andrew Cooper
2022-09-08 1:03 ` Pawan Gupta
2022-09-08 13:46 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ff23930-325b-4207-12fc-4d8fd5bea1ff@redhat.com \
--to=hdegoede@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®