From: Waiman Long <longman@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ingo Molnar <mingo@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
luto@amacapital.net, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>,
Juri Lelli <juri.lelli@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>
Subject: Re: [PATCH v10 3/9] cpuset: Simulate auto-off of sched.domain_root at cgroup removal
Date: Thu, 21 Jun 2018 16:22:05 +0800 [thread overview]
Message-ID: <6fffa761-a4ab-9974-c6b7-8c2af9d8a875@redhat.com> (raw)
In-Reply-To: <20180620141144.GI2494@hirez.programming.kicks-ass.net>
On 06/20/2018 10:11 PM, Peter Zijlstra wrote:
> On Mon, Jun 18, 2018 at 12:14:02PM +0800, Waiman Long wrote:
>> @@ -1058,7 +1060,12 @@ static int update_reserved_cpumask(struct cpuset *cpuset,
>> * Check if any CPUs in addmask or delmask are in the effective_cpus
>> * of a sibling cpuset. The implied cpu_exclusive of a scheduling
>> * domain root will ensure there are no overlap in cpus_allowed.
>> + *
>> + * This check is skipped if the cpuset is dying.
> Comments that state what the code does are mostly useless; please
> explain _why_ if anything.
I am adding more restrictions on where the domain_root can be turned on
to make sure that there will be no surprise.
I have a script to test the new cpuset v2 functionality and found that
cgroup deletion may sometime failed if there was not enough time for the
previous operation to complete. That is the reason why I relax the
checking for dying cgroup to make my test script pass.
Cheers,
Longman
next prev parent reply other threads:[~2018-06-21 8:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 4:13 [PATCH v10 0/9] cpuset: Enable cpuset controller in default hierarchy Waiman Long
2018-06-18 4:14 ` [PATCH v10 1/9] " Waiman Long
2018-06-18 4:14 ` [PATCH v10 2/9] cpuset: Add new v2 cpuset.sched.domain_root flag Waiman Long
2018-06-20 14:27 ` Peter Zijlstra
2018-06-21 7:58 ` Waiman Long
2018-06-21 8:05 ` Waiman Long
2018-06-21 9:20 ` Peter Zijlstra
2018-06-22 3:00 ` Waiman Long
2018-07-02 16:32 ` Tejun Heo
2018-06-21 9:27 ` Peter Zijlstra
2018-06-22 2:48 ` Waiman Long
2018-06-18 4:14 ` [PATCH v10 3/9] cpuset: Simulate auto-off of sched.domain_root at cgroup removal Waiman Long
2018-06-20 14:11 ` Peter Zijlstra
2018-06-21 8:22 ` Waiman Long [this message]
2018-06-18 4:14 ` [PATCH v10 4/9] cpuset: Allow changes to cpus in a domain root Waiman Long
2018-06-18 4:14 ` [PATCH v10 5/9] cpuset: Make sure that domain roots work properly with CPU hotplug Waiman Long
2018-06-20 14:15 ` Peter Zijlstra
2018-06-21 3:09 ` Waiman Long
2018-06-18 4:14 ` [PATCH v10 6/9] cpuset: Make generate_sched_domains() recognize isolated_cpus Waiman Long
2018-06-18 14:44 ` Waiman Long
2018-06-18 14:58 ` Juri Lelli
2018-06-18 4:14 ` [PATCH v10 6/9] cpuset: Make generate_sched_domains() recognize reserved_cpus Waiman Long
2018-06-20 14:17 ` Peter Zijlstra
2018-06-21 8:14 ` Waiman Long
2018-06-18 4:14 ` [PATCH v10 7/9] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root Waiman Long
2018-06-18 4:14 ` [PATCH v10 8/9] cpuset: Don't rebuild sched domains if cpu changes in non-domain root Waiman Long
2018-06-18 4:14 ` [PATCH v10 9/9] cpuset: Allow reporting of sched domain generation info Waiman Long
2018-06-20 14:20 ` Peter Zijlstra
2018-06-18 14:20 ` [PATCH v10 0/9] cpuset: Enable cpuset controller in default hierarchy Juri Lelli
2018-06-18 15:07 ` Waiman Long
2018-06-19 9:52 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fffa761-a4ab-9974-c6b7-8c2af9d8a875@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®