From: "Stéphane Grosjean" <stephane.grosjean@free.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "Vincent Mailhol" <mailhol@kernel.org>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
"Stéphane Grosjean" <s.grosjean@peak-system.fr>
Subject: Re: [PATCH] can: peak_usb: Add support of loopback mode to the PCAN-USB FD family
Date: Wed, 30 Sep 2026 16:24:44 +0200 (CEST) [thread overview]
Message-ID: <700277696.812114266.1790778284780.JavaMail.root@zimbra65-e11.priv.proxad.net> (raw)
In-Reply-To: <20260930-foamy-nostalgic-elk-30d429-mkl@pengutronix.de>
> > @@ -1266,7 +1272,7 @@ const struct peak_usb_adapter pcan_usb_fd = {
> > .ctrlmode_supported = CAN_CTRLMODE_FD |
> > CAN_CTRLMODE_3_SAMPLES | CAN_CTRLMODE_LISTENONLY |
> > CAN_CTRLMODE_ONE_SHOT | CAN_CTRLMODE_CC_LEN8_DLC |
> > - CAN_CTRLMODE_BERR_REPORTING,
> > + CAN_CTRLMODE_BERR_REPORTING | CAN_CTRLMODE_LOOPBACK,
>
> Can you keep the CAN_CTRLMODE sorted by their value?
>
> Please make an incremental patch for the CAN_CTRLMODE_BERR_REPORTING,
> I'll squash that...and add CAN_CTRLMODE_LOOPBACK in the appropriate
> place.
>
Hello Marc,
Do you want me to post a v2 of this patch with the CAN_CTRLMODE flags sorted by value, or do you prefer a separate incremental patch on top of the bus error reporting series?
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung Nürnberg | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
>
next prev parent reply other threads:[~2026-09-30 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 13:34 Stéphane Grosjean
2026-09-30 13:51 ` Marc Kleine-Budde
2026-09-30 14:24 ` Stéphane Grosjean [this message]
2026-09-30 14:43 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700277696.812114266.1790778284780.JavaMail.root@zimbra65-e11.priv.proxad.net \
--to=stephane.grosjean@free.fr \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.grosjean@peak-system.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®