mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-pm@vger.kernel.org
Cc: Enric Balletbo Serra <enric.balletbo@collabora.com>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] power: supply: Add driver for Microchip UCS1002
Date: Tue, 30 Apr 2019 20:43:24 -0700	[thread overview]
Message-ID: <7002fe8e-7686-fe84-374f-766f99f8317d@infradead.org> (raw)
In-Reply-To: <20190501033434.18548-3-andrew.smirnov@gmail.com>

Hi,

On 4/30/19 8:34 PM, Andrey Smirnov wrote:
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index e901b9879e7e..c614c8a196f3 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -660,4 +660,13 @@ config FUEL_GAUGE_SC27XX
>  	 Say Y here to enable support for fuel gauge with SC27XX
>  	 PMIC chips.
>  
> +config CHARGER_UCS1002
> +        tristate "Microchip UCS1002 USB Port Power Controller"

Please indent the tristate line with a tab instead of spaces.

> +	depends on I2C
> +	depends on OF
> +	select REGMAP_I2C
> +	help
> +	  Say Y to enable support for Microchip UCS1002 Programmable
> +	  USB Port Power Controller with Charger Emulation.
> +
>  endif # POWER_SUPPLY


thnx.
-- 
~Randy

  reply	other threads:[~2019-05-01  3:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  3:34 [PATCH v5 0/3] Driver for UCS1002 Andrey Smirnov
2019-05-01  3:34 ` [PATCH v5 1/3] power: supply: core: Add POWER_SUPPLY_HEALTH_OVERCURRENT constant Andrey Smirnov
2019-05-01  3:34 ` [PATCH v5 2/3] power: supply: Add driver for Microchip UCS1002 Andrey Smirnov
2019-05-01  3:43   ` Randy Dunlap [this message]
2019-05-01  4:22     ` Andrey Smirnov
2019-05-01 13:21   ` Guenter Roeck
2019-05-01  3:34 ` [PATCH v5 3/3] dt-bindings: power: supply: Add bindings " Andrey Smirnov
2019-05-01 22:43 ` [PATCH v5 0/3] Driver for UCS1002 Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7002fe8e-7686-fe84-374f-766f99f8317d@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=enric.balletbo@collabora.com \
    --cc=festevam@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®