From: Thorsten Blum <thorsten.blum@linux.dev>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Huth <thuth@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] x86/mtrr: Replace simple_strtoul with kstrtoul in parse_mtrr_spare_reg
Date: Sun, 1 Mar 2026 17:23:00 +0100 [thread overview]
Message-ID: <70047072-6F3E-44D0-BF73-CAFC7C1AF9A5@linux.dev> (raw)
In-Reply-To: <20260228145818.GBaaMCighSpuxSUDPO@fat_crate.local>
On 28. Feb 2026, at 15:58, Borislav Petkov wrote:
> On Tue, Jan 27, 2026 at 10:58:23PM +0100, Thorsten Blum wrote:
>> Replace simple_strtoul() with the recommended kstrtoul() for parsing the
>> 'mtrr_spare_reg_nr' boot parameter.
>>
>> Check the return value of kstrtoul() and reject invalid values.
>
> Where?
The check is implicit in the return statement. Previously,
parse_mtrr_spare_reg() always returned 0 (success). Returning kstrtoul()
directly propagates 0 on success and -errno on failure, which adds
proper error handling.
However, I realized that 'arg' can be NULL here, so the NULL check
cannot be removed. I'll send a v2.
Thanks,
Thorsten
prev parent reply other threads:[~2026-03-01 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 21:58 Thorsten Blum
2026-02-28 14:58 ` Borislav Petkov
2026-03-01 16:23 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70047072-6F3E-44D0-BF73-CAFC7C1AF9A5@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=thuth@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®