From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761161AbbBITEx (ORCPT ); Mon, 9 Feb 2015 14:04:53 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:50302 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519AbbBITEv (ORCPT ); Mon, 9 Feb 2015 14:04:51 -0500 Date: Mon, 9 Feb 2015 20:02:21 +0100 (CET) From: Stefan Wahren Reply-To: Stefan Wahren To: "H. Peter Anvin" , Linus Walleij , Dmitry Eremin-Solenikov , Support Opensource , Darren Hart , Robert Jarzmik , linux-pm@vger.kernel.org, Samuel Ortiz , Lee Jones , ac100@lists.launchpad.net, Cezary Jackiewicz , Russell King , patches@opensource.wolfsonmicro.com, Milo Kim , David Herrmann , devel@driverdev.osuosl.org, Len Brown , linux-acpi@vger.kernel.org, Ingo Molnar , linux-input@vger.kernel.org, "Rafael J. Wysocki" , linux-tegra@vger.kernel.org, Daniel Mack , Krzysztof Kozlowski , platform-driver-x86@vger.kernel.org, Sebastian Reichel , Julian Andres Klode , linux-arm-kernel@lists.infradead.org, Marc Dietrich , David Woodhouse , Jiri Kosina , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, x86@kernel.org, Haojian Zhuang Cc: Bartlomiej Zolnierkiewicz , Pavel Machek , Thomas Gleixner , Kyungmin Park Message-ID: <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de> In-Reply-To: <1422629278-12202-5-git-send-email-k.kozlowski@samsung.com> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-5-git-send-email-k.kozlowski@samsung.com> Subject: Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.0-Rev36 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:+EKvEJ2HLVjnpC6CttqWBi1MldM0kQNfmCPix9C6v3gG8aqmZ9E ZQ2J4ELbmf5O021NuCWjUnwFzEo9k0YAgyk4z8yBvHHSHDm3Y5aiAllQa179O24X1ttSmXV jsUe/9oliniCDVZVF7mM2jeXuExQ4Xz+K+t74fGVWKDYoEHIUGHj/gf6p9wHP0XLmhogg4l oZo2/AfDkhcynj8UZpi6Q== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, > Krzysztof Kozlowski hat am 30. Januar 2015 um 15:47 > geschrieben: > > > Replace direct calls to power supply function attributes with wrappers. > Wrappers provide safe access in case of unregistering the power > supply (e.g. by removing the driver). Replace: > - get_property -> power_supply_get_property > - set_property -> power_supply_set_property > - property_is_writeable -> power_supply_property_is_writeable > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Jonghwa Lee just a nit. It looks like a typo in the mail address which is also in patch 5 - 10. I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and didn't see any problems with your patches. Stefan > Acked-by: Pavel Machek > Reviewed-by: Bartlomiej Zolnierkiewicz > Reviewed-by: Sebastian Reichel > ---