From: "Jaya Kumar" <jayakumar.video@gmail.com>
To: "Oliver Neukum" <oliver@neukum.org>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH/RFC 2.6.16.5 1/1] usb/media/quickcam_messenger driver
Date: Mon, 15 May 2006 07:22:37 +0800 [thread overview]
Message-ID: <70066d530605141622o30c9497dp8f571b575b2a706e@mail.gmail.com> (raw)
In-Reply-To: <200605141812.29333.oliver@neukum.org>
On 5/15/06, Oliver Neukum <oliver@neukum.org> wrote:
> Am Sonntag, 14. Mai 2006 16:11 schrieb jayakumar.video@gmail.com:
> > +static int qcm_setup_on_open(struct uvd *uvd)
> > +{
> > +qcm_sensor_set_gains(uvd, uvd->vpic.hue,
> > +uvd->vpic.colour, uvd->vpic.contrast);
> > +qcm_sensor_set_exposure(uvd, uvd->vpic.brightness);
> > +qcm_sensor_set_shutter(uvd, uvd->vpic.whiteness);
> > +qcm_set_camera_size(uvd);
> > +qcm_camera_on(uvd);
> > +return 0;
> > +}
>
> This function can generate IO errors. You should not simply drop them.
You are right. I was lazy about that. I'll put in a macro like
CHECK_RET(qcm_camera_on) for all the calls that do IO.
Thanks,
jaya
prev parent reply other threads:[~2006-05-14 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-14 14:11 jayakumar.video
[not found] ` <200605141824.28161.oliver@neukum.org>
2006-05-14 23:19 ` Jaya Kumar
2006-05-15 6:24 ` [linux-usb-devel] " Oliver Neukum
[not found] ` <200605141812.29333.oliver@neukum.org>
2006-05-14 23:22 ` Jaya Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70066d530605141622o30c9497dp8f571b575b2a706e@mail.gmail.com \
--to=jayakumar.video@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®