From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Vlad Poenaru <vlad.wing@gmail.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org
Cc: mason@kernel.org, osandov@osandov.com, josef@toxicpanda.com,
fdmanana@suse.com, boris@bur.io, linux-kernel@vger.kernel.org,
kernel-team@meta.com, stable@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix bytes_may_use underflow after a failed tree block allocation
Date: Sat, 14 Nov 2026 08:05:47 +1030 [thread overview]
Message-ID: <700e302d-c85e-4bd8-84b1-0e6eb8565740@gmx.com> (raw)
In-Reply-To: <20261113170926.1468850-1-vlad.wing@gmail.com>
在 2026/11/14 03:39, Vlad Poenaru 写道:
[...]
>
> Fixes: 67b7859e9bfa ("btrfs: handle ENOMEM in btrfs_alloc_tree_block")
> Cc: stable@vger.kernel.org # 6.16+
> Signed-off-by: Vlad Poenaru <vlad.wing@gmail.com>
Can you simplify the commit message, not only by a little but by a ton?
I'm not against LLM generated commit message/code, but the end result
should still be human reader friendly.
This looks very ChatGPT, which I hate a lot as chatGPT commit messages
are a pain in the backend.
This over 100 lines commit message is definitely not human-friendly. I
hate if I need to use LLM to just summarize the commit message.
To be honest, most (if not all) of your commit message can be extracted
into a single call trace graph:
btrfs_alloc_tree_block()
|- btrfs_use_block_rsv()
|- btrfs_reserve_extent()
| \- btrfs_add_reserved_bytes() <- bytes_may_use -= blocksize
|
|- btrfs_init_new_buffer()
| \- alloc_extent_buffer() <- fails with -ENOMEM
|
|- btrfs_free_reserved_extent() <- bytes_reserved -= blocksize
\- btrfs_unuse_block_rsv() <- block rsv += blocksize again
I really hope you can update the memory file to let your agent not
generate too much words salads.
prev parent reply other threads:[~2026-11-13 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 17:09 Vlad Poenaru
2026-11-13 20:12 ` Boris Burkov
2026-11-13 21:35 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700e302d-c85e-4bd8-84b1-0e6eb8565740@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=boris@bur.io \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@kernel.org \
--cc=osandov@osandov.com \
--cc=stable@vger.kernel.org \
--cc=vlad.wing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®