From: Ferry Toth <fntoth@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Felipe Balbi <balbi@kernel.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>
Subject: Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to the right controller"
Date: Mon, 4 Oct 2021 22:35:57 +0200 [thread overview]
Message-ID: <7019ca3e-f076-e65b-f207-c23a379ade29@gmail.com> (raw)
In-Reply-To: <20211004141839.49079-1-andriy.shevchenko@linux.intel.com>
Hi,
Op 04-10-2021 om 16:18 schreef Andy Shevchenko:
> The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right
> controller") changed the device for the UDC and broke the user space scripts
> that instantiate the USB gadget(s) via ConfigFS.
I confirm this regression on Intel Edison since at least 5.15-rc2 while
in 5.14.0 it was working fine.
This patch resolves the issue as tested on 5.15-rc4.
Tested-by: Ferry Toth<fntoth@gmail.com>
> Revert it for now until the better solution will be proposed.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/usb/dwc3/gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 8e66a70adae6..13664609ed3c 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4253,7 +4253,7 @@ int dwc3_gadget_init(struct dwc3 *dwc)
> }
>
>
> - usb_initialize_gadget(dwc->sysdev, dwc->gadget, dwc_gadget_release);
> + usb_initialize_gadget(dwc->dev, dwc->gadget, dwc_gadget_release);
> dev = &dwc->gadget->dev;
> dev->platform_data = dwc;
> dwc->gadget->ops = &dwc3_gadget_ops;
next prev parent reply other threads:[~2021-10-04 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 14:18 Andy Shevchenko
2021-10-04 20:35 ` Ferry Toth [this message]
2021-10-05 8:51 ` Michael Grzeschik
2021-10-05 9:17 ` Andy Shevchenko
2021-10-05 10:49 ` Felipe Balbi
2021-10-05 11:04 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7019ca3e-f076-e65b-f207-c23a379ade29@gmail.com \
--to=fntoth@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome