mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: WGH <da-wgh@ya.ru>,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: cdc_ncm doesn't detect link unless ethtool is run (ASIX AX88179B)
Date: Sat, 15 Nov 2025 13:33:48 +0100	[thread overview]
Message-ID: <701e5678-a992-45be-9be3-df68dfe14705@suse.com> (raw)
In-Reply-To: <1c3f0582-4c92-41b3-a3db-5158661d4e1a@ya.ru>

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

On 15.11.25 09:58, WGH wrote:
> Hello.
> 
> I'm running Linux 6.17.7, and recently obtained a UGREEN 6 in 1 hub containing an AX88179B chip.
> 
> By default, it uses the generic cdc_ncm driver, and it works mostly okay.
> 
> The annoying problem I have is that most of the time the kernel doesn't notice that the link is up. ip link reports NO-CARRIER, network management daemon doesn't configure the interface, and so on.

Hi,

that strongly points to a race condition.
Could you try the attached diagnostic patch?

	Regards
		Oliver

[-- Attachment #2: ncm_bind_uncond.patch --]
[-- Type: text/x-patch, Size: 442 bytes --]

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 1d9faa70ba3b..d042ba574217 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1892,7 +1892,7 @@ usbnet_probe(struct usb_interface *udev, const struct usb_device_id *prod)
 
 	netif_device_attach(net);
 
-	if (dev->driver_info->flags & FLAG_LINK_INTR)
+	//if (dev->driver_info->flags & FLAG_LINK_INTR)
 		usbnet_link_change(dev, 0, 0);
 
 	return 0;

  reply	other threads:[~2025-11-15 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-15  8:58 WGH
2025-11-15 12:33 ` Oliver Neukum [this message]
2025-11-17 12:44   ` WGH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=701e5678-a992-45be-9be3-df68dfe14705@suse.com \
    --to=oneukum@suse.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=da-wgh@ya.ru \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®