From: Marek Vasut <marek.vasut@mailbox.org>
To: Thomas Gleixner <tglx@kernel.org>, linux-input@vger.kernel.org
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
Cheng-Yang Chou <yphbchou0911@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Frank Li <Frank.Li@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Marc Zyngier <maz@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ with valid IRQ check
Date: Wed, 28 Jan 2026 13:23:42 +0100 [thread overview]
Message-ID: <701e739d-2e82-40e7-87b5-b4ec92903af6@mailbox.org> (raw)
In-Reply-To: <87sebrbenj.ffs@tglx>
On 1/27/26 10:14 AM, Thomas Gleixner wrote:
> On Thu, Jan 22 2026 at 00:23, Marek Vasut wrote:
>
> $Subject: linux/interrupt.h is not a proper prefix. Just use 'genirq:'
>
> Also what means 'allow ....'? Subject lines should provide a concise
> summary of the change, i.e. something like:
>
> Provide conditional disable_irq guard variant
I did admittedly replicate the subject and tags from prior commit
c76494768761 ("linux/interrupt.h: allow "guard" notation to disable and
reenable IRQ")
Fixed, thanks.
>> Introduce disable_valid_irq scoped guard. This is an extension
>> of disable_irq scoped guard, which disables and enables IRQs
>> around a scope. The disable_valid_irq scoped guard does almost
>> the same, except it handles the case where IRQ is not valid,
>> in which case it does not do anything. This is meant to be used
>> by for example touch controller drivers, which can do both IRQ
>> driven and polling mode of operation, and this makes their code
>> slighly simpler.
>
> How many of those have this pattern? From a cursory look I found not
> even one as your example is neither applicable to upstream nor to next.
One. I think I have two-ish more candidates for conversion.
>> +static inline void disable_valid_irq(unsigned int irq)
>> +{
>> + if (irq > 0)
>> + disable_irq(irq);
>> +}
>> +
>> +static inline void enable_valid_irq(unsigned int irq)
>> +{
>> + if (irq > 0)
>> + enable_irq(irq);
>> +}
>> +
>> +DEFINE_LOCK_GUARD_1(disable_valid_irq, int,
>
> 'int' because it matches the function argument type of the inlines,
> right?
>
>> + disable_valid_irq(*_T->lock), enable_valid_irq(*_T->lock))
>
> disable_valid_irq is a pretty non-intuitive name if you look at it just
> by reading a usage site. It's not really improving the readability of
> the code, it's in fact obscuring it as the reader has to actually look
> up what the hell this means and then stumble upon a completely
> undocumented lock guard define.
>
> I'm all for using guards, but using guards just for the sake of using
> guards is not a really good approach.
I wouldn't even be opposed to converting the ili2xxx driver (the piece
of code in patch 2/2 of this series) back to simple enable/disable_irq()
. I am not particularly on board even with the disable_irq lock guard,
or more specifically, lock guard used for non-lock things like this.
next prev parent reply other threads:[~2026-01-28 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 23:23 Marek Vasut
2026-01-21 23:23 ` [PATCH 2/2] Input: ili210x - convert to disable_valid_irq scoped guard Marek Vasut
2026-01-22 15:38 ` [PATCH 1/2] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ with valid IRQ check Frank Li
2026-01-22 19:11 ` Marek Vasut
2026-01-22 16:22 ` Sebastian Andrzej Siewior
2026-01-22 16:31 ` Geert Uytterhoeven
2026-01-22 18:38 ` Dmitry Torokhov
2026-01-22 18:57 ` Sergey Shtylyov
2026-01-23 10:52 ` Thomas Gleixner
2026-01-25 5:30 ` Dmitry Torokhov
2026-01-27 9:14 ` Thomas Gleixner
2026-01-28 12:23 ` Marek Vasut [this message]
2026-01-28 13:49 ` Thomas Gleixner
2026-01-28 14:33 ` Marek Vasut
2026-02-12 18:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=701e739d-2e82-40e7-87b5-b4ec92903af6@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Frank.Li@nxp.com \
--cc=bigeasy@linutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=ruanjinjie@huawei.com \
--cc=tglx@kernel.org \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®