mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support
Date: Wed, 8 Dec 2021 15:51:49 +0100	[thread overview]
Message-ID: <701f4954-5dc8-9b4f-674c-c40d7e6e3df1@foss.st.com> (raw)
In-Reply-To: <87ee6n18im.wl-maz@kernel.org>

On 12/8/21 3:22 PM, Marc Zyngier wrote:
> Hi Alexandre,
> 
> On Wed, 08 Dec 2021 13:58:46 +0000,
> Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote:
>>
>>> Why does the driver need to carry these tables? This sort of
>>> information should really come from DT, instead of being hardcoded in
>>> the driver and bloating it for no reason. This all has a funny taste
>>> of the board files we used to have pre-DT.
>>>
>>
>> There are absolutely no reason to have it in driver. Honestly It has
>> been done in this way to have minimal changes adding this new SoC
>> support (and it's not smart, I agree).
>>
>> I think it is better to abandon this series. I will create a new one
>> which moves mapping table for MP15 and adds MP13 support to.
> 
> I'm afraid you'll have to keep the in-kernel table for MP15, since the
> driver needs to work with old DTs. For new SoCs (such as MP13), moving
> the table into DT would be good.

I can try to have both for MP15:use new mechanism as MP13 and keep the 
table inside the driver as a fallback if DT mapping is not provided (for 
old DT).

Thanks

> 
> Thanks,
> 
> 	M.
> 


  reply	other threads:[~2021-12-08 14:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 13:04 [PATCH 0/3] Add STM32MP13 EXTI support Alexandre Torgue
2021-12-08 13:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: stm32-exti: document st,stm32mp13-exti Alexandre Torgue
2021-12-08 13:04 ` [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support Alexandre Torgue
2021-12-08 13:41   ` Marc Zyngier
2021-12-08 13:58     ` Alexandre TORGUE
2021-12-08 14:22       ` Marc Zyngier
2021-12-08 14:51         ` Alexandre TORGUE [this message]
2021-12-08 13:04 ` [PATCH 3/3] ARM: dts: stm32: Enable EXTI on stm32mp13 Alexandre Torgue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=701f4954-5dc8-9b4f-674c-c40d7e6e3df1@foss.st.com \
    --to=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®