From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCF34A2A66 for ; Wed, 14 Oct 2026 08:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791966498; cv=none; b=PcDWbusr9xlbY5DJ+lDAn0lGkCHBzfw+o0mK9R7JALrDHlEXTAQ3pwPyC7WDB/RlnEOWSarBbaHG3fKYMIF2upJmCPn8CBrKiEKUSRBFMRSCWGdqCOv9JsYkz7eI96Za/1S/1tfLCVNcUSbGHNnQUrkrrApvBIvVo8Zqwe/Z6/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791966498; c=relaxed/simple; bh=28AGN6pwCeJyoglmxkpbJsqh/NL6EeY9xBrx5No80m0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ED9zgcKz1Hw6683Czdaz5HQMC1l5Qfp91OGqjk7DvYnhErI3lJ/c1gMHnFOXeezCZhW7JwIdWTboX8Abo+UIileUO0d65ECJKESVKlNuDJ8ImwMLaaSdEr6tgzDFvKl2Zy1uHmXcixuodrvBGslmetIyMRZ340Z2raEuaEjsL48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G5wEV+yy; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G5wEV+yy" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4a19cba5c14so31748465e9.3 for ; Wed, 14 Oct 2026 01:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1791966494; x=1792571294; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BEWX0NnWZSM0xUTF33KaixK1TLeuUgRnotvYl3b7sMI=; b=G5wEV+yyO0uEYc/VYtGpl50eKe0T6EWkecGt7kI8lLAthE3ATq4quZucttNWKHMytQ 5uI2fFyL1qUlcQD2treZy1GArgb4fXMWwo6qw95U/amPj7jYAwGYEgdvCgN+rQNMScTy JGxck0WzHyzvxuyGjHZTk9o91cjobQ9V8X2KJ/Y5LoyRkirXBeLs6iRFKaoDjNgcStPt VfWnvNCX9U37FMCN+/DjzVUWASVyBfzC/wl76Zj3xxj0bPuGC1J0M2K1d0AlunXapoTY mvjHMyYpcGd85h6EUx6yUW98VWUcA1mzMY6lKLlz6TMtEEhvdvBcbkh2s6KgtN4lFOKy UTcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791966494; x=1792571294; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=BEWX0NnWZSM0xUTF33KaixK1TLeuUgRnotvYl3b7sMI=; b=VR4CPdILCbKD2ZfPnI4luLFxdP3ZHMeJyYhohMacYZPCab4DEF3l7x3mpjiAUn9yNN wQtzU2WUdaWT8yhK/vGH2li4eMThkMy9I11415r1WOf5FYYT7vD1+S7vDxDLopnh7WVt jKS78MI+gF1Z8Q8m7Fsxcdpt8iBNVstoryCRwkYtv047PgcZiSk6zUHEf3Fnl35yd41y NMVbeQvqkCLvw1iE+GMetIudvffyrJd/OIthUwO8rccCGjvnbfo3E97p9tmxHaYnc/fK QlTuZf1zMCPxFJTbTRkbG7IDlvfM22rxRI6MD4m324Wlo0E83ZDOAHGSY9c9RX37vuM9 fRqQ== X-Forwarded-Encrypted: i=1; AKwUvBxqUn88qUU4QI/4R/i9bqyzCbg2z0PPg/3oeFC0PPAxkvV5HjziHffuP7HntFBAUCNlzPqIo9IexuUJzuA=@vger.kernel.org X-Gm-Message-State: AFq9FYLrP+Vg9u3LxZdjlCvWO8txSwQ5F7lYWavLwHX8ysGFtJ6K7iX0 iOAHPkT6sl4aFqgzrj0INTbEgkcr7767SMRgpzcst9L3YNPAowb0lYBpnwEqJnsrmyg= X-Gm-Gg: AYBFou2yuhw7+UfN7VQGkfbKNN/UQxnvP4nOt7LbB2VD290x7SEZ2ZBWOzC0LVr1+1A 0bu8xRUjqqH+YBxTLmBiTzuTM9ZSQP65TLaAqtJIPOppRiZcjOfaBP8EIGDn5wn8OeaToCaY9/g VWIWh7mpnHiMr287yu9f3xG/Zh18G8KGJfHs/rgNOn11nVrPtIiv0aaqg/vUzKv1JBO7FBmTas4 XrcVC+JO/NMPGLVNIRP3iIO9q6aNhddMWAIfpXr+8wYOWokx900r+tHWHrOdAV8BrVspUuja2O2 8Fsbfh0utRnaW6Y6xwpsnnBGTn/kc4Jie+SXnyFexmnOelPRGxZUscm1OJR1DtkdXfMe9okFOej nHYdiryQRVVdn5uzWRtvTYGVlEdTEFm6t8yEiT947u2mMu814OD2DR+0h4JSnN2mQa2F/yX9yWQ +PN6bBBrk6PSTtlAj58l7jepis800bixPc6QhcDathImohNfz234rTpUYUbyO8kLbpp0QMEBVvs ryY6ZupEZ2BBGAyPKS42ETNHZNqmM3CTshaNnXV6XNwGJkRCr7vYX8= X-Received: by 2002:a05:600c:8b04:b0:4a0:1e37:ae41 with SMTP id 5b1f17b1804b1-4a18e4d67edmr291581105e9.24.1791966494135; Wed, 14 Oct 2026 01:28:14 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:ef1f:5ab3:36fa:3ccb? ([2a01:e0a:106d:1080:ef1f:5ab3:36fa:3ccb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1b4b8a184sm17182865e9.2.2026.10.14.01.28.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 01:28:13 -0700 (PDT) Message-ID: <7020a7a6-332e-4fd0-a659-d82eb768614c@linaro.org> Date: Wed, 14 Oct 2026 10:28:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 2/2] dt-bindings: usb: snps,dwc3: Fix downstream port numbering To: Chen-Yu Tsai , Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Sven Peter , Janne Grunau , Neal Gompa , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Michal Simek , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Heiko Stuebner , Alim Akhtar , Kunihiko Hayashi , Masami Hiramatsu , Yixun Lan , Troy Mitchell , Minda Chen , Shyam Pandey , Wei Yang , Senchuan Zhang , Hang Cao , Li Jun , Peng Fan , Roy Luo , Yang Xiwen , Ahmad Zainie , Robert Marko , Xu Yang , Wesley Cheng , Stanley Chang , Ze Huang , Aswath Govindraju , Roger Quadros , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev References: <20261014082037.1774672-1-wenst@chromium.org> <20261014082037.1774672-3-wenst@chromium.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20261014082037.1774672-3-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/14/26 10:20, Chen-Yu Tsai wrote: > The DWC3 controller can operate in host mode. It does so with a XHCI > compliant host controller. The XHCI has two downstream ports, one for > HS and one for SS. USB downstream ports start from 1, not 0. Is there something in index 0 we will need to define at some point ? Using 0 as base for numbering in DT isn't incompatible with the USB spec using base 1 for numbering, > > Reconcile the downstream port numbering with the common USB host > binding, renumbering the downstream port numbers from 0 and 1 to > 1 and 2. > > This is non-backwards compatible, however it won't break current > major implementations: > > - dwc3 "gadget mode" in Linux kernel only requires a connection to be > present; it doesn't matter which port it is > - dwc3 "host mode" OF graph connections aren't supported yet [1] > - FreeBSD doesn't use the OF graph for anything > - U-boot doesn't use the OF graph for USB > - OpenBSD doesn't support dwc3, only the XHCI in dwc3, and doesn't use > the OF graph for USB > - coreboot doesn't use the OF graph for anything > - Zephyr doesn't support dwc3 > - TF-A doesn't use the OF graph for anything > - EDK2 doesn't support dwc3 and doesn't support OF graph > - OP-TEE doesn't support dwc3 and doesn't support OF graph > > [1] WIP to tie OF graph port node to USB port device > > Fixes: a33113f73693 ("dt-bindings: usb: snps,dwc3: document HS & SS OF graph ports") > Signed-off-by: Chen-Yu Tsai > --- > It is unclear to me whether the HS/SS numbering is fixed for all dwc3 > variants. I checked Allwinner H616 and Rockchip RK3588 and they both > have HS as port 1 and SS as port 2. > > This also doesn't cover a potential "multi-port" DWC3 implementation, > which Qualcomm seems to have. It breaks the current Qualcomm numbering on numerous boards. > --- > Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml > index 6c0b8b653824..4b6304bd2ec1 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3-common.yaml > @@ -410,11 +410,11 @@ properties: > property is used. > > properties: > - port@0: > + port@1: > $ref: /schemas/graph.yaml#/properties/port > description: High Speed (HS) data bus. > > - port@1: > + port@2: > $ref: /schemas/graph.yaml#/properties/port > description: Super Speed (SS) data bus. >