From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752788AbdKJKuH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Nov 2017 05:50:07 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:35295 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752467AbdKJKuG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Nov 2017 05:50:06 -0500
X-Google-Smtp-Source: AGs4zMYWsuvuhWCQqpO1so9xhIwrfFHosGzSYSLx4wHl6Ve9S3RD38pF/H9fgOpdcwf9yr+2UdFmCg==
Subject: Re: [PATCH 02/14] soundwire: Add SoundWire bus type
To: Vinod Koul <vinod.koul@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        ALSA <alsa-devel@alsa-project.org>, Mark <broonie@kernel.org>,
        Takashi <tiwai@suse.de>, Pierre <pierre-louis.bossart@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        Shreyas NC <shreyas.nc@intel.com>, patches.audio@intel.com,
        alan@linux.intel.com, Charles Keepax <ckeepax@opensource.cirrus.com>,
        Sagar Dharia <sdharia@codeaurora.org>, plai@codeaurora.org,
        Sudheer Papothi <spapothi@codeaurora.org>
References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com>
 <1508382211-3154-3-git-send-email-vinod.koul@intel.com>
 <5fee4ccb-1030-b698-e7ef-7f4390563a76@linaro.org>
 <20171110045951.GL3187@localhost> <20171110085537.GQ3187@localhost>
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <702d9153-69c5-c574-6ea3-fd2b54f23cf0@linaro.org>
Date: Fri, 10 Nov 2017 10:50:03 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20171110085537.GQ3187@localhost>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 10/11/17 08:55, Vinod Koul wrote:
>>>> +
>>>> +/**
>>>> + * sdw_get_device_id: find the matching SoundWire device id
>>>> + *
>>> function name should end with () - according to kernel doc.
>> ah thanks for pointing will add
> I ran the kernel-doc script, seems to not complain about this.
> 
> Looking at it closely scripts/kernel-doc parenthesis is not expected

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/doc-guide/kernel-doc.rst?h=v4.14-rc8#n204

Examples in the doc does suggest that we need (). Am not 100% sure if : 
is also a valid with functions.