From: Vasant Hegde <vasant.hegde@amd.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat
Date: Wed, 30 Apr 2025 16:02:36 +0530 [thread overview]
Message-ID: <702f4def-7382-4d95-8b3d-c1c10c11f627@amd.com> (raw)
In-Reply-To: <20250430025249.2371751-1-baolu.lu@linux.intel.com>
On 4/30/2025 8:22 AM, Lu Baolu wrote:
> The dev_enable/disable_feat ops have been removed by commit
> <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()").
> Cleanup the comments to make the code clean.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
> ---
> include/linux/iommu.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 1785caee5977..36df38c2d3a9 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -590,8 +590,6 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size,
> * @of_xlate: add OF master IDs to iommu grouping
> * @is_attach_deferred: Check if domain attach should be deferred from iommu
> * driver init to device driver init (default no)
> - * @dev_enable/disable_feat: per device entries to enable/disable
> - * iommu specific features.
> * @page_response: handle page request response
> * @def_domain_type: device default domain type, return value:
> * - IOMMU_DOMAIN_IDENTITY: must use an identity domain
next prev parent reply other threads:[~2025-04-30 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 2:52 Lu Baolu
2025-04-30 9:01 ` Tian, Kevin
2025-04-30 10:32 ` Vasant Hegde [this message]
2025-05-02 6:42 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=702f4def-7382-4d95-8b3d-c1c10c11f627@amd.com \
--to=vasant.hegde@amd.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®