From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72A4C433DB for ; Wed, 3 Feb 2021 03:32:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F64864F74 for ; Wed, 3 Feb 2021 03:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233040AbhBCDcl (ORCPT ); Tue, 2 Feb 2021 22:32:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232735AbhBCDbC (ORCPT ); Tue, 2 Feb 2021 22:31:02 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D751AC0617AA for ; Tue, 2 Feb 2021 19:30:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=qwvCwcChuxtahpY7NTqPCpmTFzPp7YMpsonMHOpWMJs=; b=v0LWgPEVfKiboGCZFhUvlemZX2 3SKMqGZFjp378WH+F8vozQGEWbrjScFkTP1F1N1iCOHknl28nj3/VeyIRwNJ8OEwdJ6KbhLNJqE5h +uCFW+BdTB5gL5SIhY8Zg2X0KYN3hdDxJ85Dk57Jbin7KaJaTw/V3pCFXRGoaWhrJPS2PqJislbYa 10SuJFausicUvheoY/yH/LVHKopcTtbpC7X+WXfw9uUb2FDP+JR1g/wGGNxMONnudIl/GCWMx+i9d u5iaj8XcMRNq+AjPx2+JJBNqrSKGMqy47M8kb6KhZKtm2nmD7/1TPPgMC0AieE85XCoMjnf7sEBzh nnXKieWQ==; Received: from [2601:1c0:6280:3f0::2a53] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l78s9-0001XB-I1; Wed, 03 Feb 2021 03:30:29 +0000 Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed To: Sergey Senozhatsky , Timur Tabi Cc: Petr Mladek , Steven Rostedt , linux-kernel@vger.kernel.org, vbabka@suse.cz, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, keescook@chromium.org, john.ogness@linutronix.de, akinobu.mita@gmail.com References: <20210202213633.755469-1-timur@kernel.org> From: Randy Dunlap Message-ID: <702f6f68-7455-337b-e0f3-6947a51c142e@infradead.org> Date: Tue, 2 Feb 2021 19:30:23 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/21 7:24 PM, Sergey Senozhatsky wrote: > On (21/02/02 15:36), Timur Tabi wrote: >> If the make-printk-non-secret command-line parameter is set, then >> printk("%p") will print addresses as unhashed. This is useful for >> debugging purposes. >> >> A large warning message is displayed if this option is enabled, >> because unhashed addresses, while useful for debugging, exposes >> kernel addresses which can be a security risk. >> >> Signed-off-by: Timur Tabi > > Looks good to me. > > Acked-by: Sergey Senozhatsky > > -ss Acked-by: Randy Dunlap thanks. -- ~Randy