From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 867B241C69 for ; Mon, 7 Oct 2024 09:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728293800; cv=none; b=Pdu52nv4YYS4KuaKKrBcinGVhmGYfAzUFDa1Sg1Gi34ULFJQcDuYr3d4tKtaXnhQJYs0pTsmtQ8iGaHvw3ZC59w7dQvH00y7dGPVqA080jIP1RCvOuqzHjNcMpMNDmJ43EC4W0pI7r0feNlPCfjkO9bNwtQC3pY/OLjdd+zIz5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728293800; c=relaxed/simple; bh=pWjov5Fcb9t1OXwN3B6DkMW278o+8JHNmlMCNyJ1DB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NqhBpNxHvfm+1esvm46jxMNzEL/V27PoRpPfJnpjCFDzNKUjo1Wq2ULS0c9y8LqgCTKB7ABLbygfdlppyAdXhoTPO1Jpw9Y4gv03Y/cS9g8kozJyKb+NjzI7qE0D1ZH+1sPEzAT6+Xw+8Vw6ZbJRFx9rH1pIzQboenSHugaLgg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jgMLBtwT; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jgMLBtwT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1728293796; bh=pWjov5Fcb9t1OXwN3B6DkMW278o+8JHNmlMCNyJ1DB4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jgMLBtwTMgZCwf39YRE5Y2Qx59/Mxvnny0ZqiUtOfMbub5R6Ry+Bv4I4eTRfIYVVP 2FjxMZIB2yC4WoaUP68qPFWX2SFY2/YW5dbECRS7ug++I7K1Q9DvEM84LKI8jSlaJD rshdeJml2fRMw5UX9Q3G9wD+sPdo0iYb3RfMB486x4sdkWllhnHWGNBsbXJK9pmcEQ b7YWduc5ly+k87bfXpUotE0j76ndQWHbI8K2tpTdxt8sdYRum4UN+6qktjueEa0htL Nl6ycsTQGz0qX+tC6qfAvZ5Iy3Ylkf1vBwnYKKmEuuXd4x9c5zbH2X/z0VaMgWbpkv rbNENBqkwbW3g== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1B5FC17E1166; Mon, 7 Oct 2024 11:36:36 +0200 (CEST) Message-ID: <703213a8-1ac6-4c8d-9487-ea1dbdabec40@collabora.com> Date: Mon, 7 Oct 2024 11:36:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/5] drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs To: "Jason-JH.Lin" , Adam Thiede , Yassine Oudjana , Chun-Kuang Hu Cc: Shawn Sung , Alper Nebi Yasak , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Singo Chang , Nancy Lin , Project_Global_Chrome_Upstream_Group@mediatek.com References: <20241007070101.23263-1-jason-jh.lin@mediatek.com> <20241007070101.23263-2-jason-jh.lin@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20241007070101.23263-2-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 07/10/24 09:00, Jason-JH.Lin ha scritto: > If the constant alpha always enable, the SoCs that is not supported the > ignore pixel alpha bit will still use constant alpha. That will break > the original constant alpha setting of XRGB foramt for blend_modes > unsupported SoCs, such as MT8173. > > Note that ignore pixel alpha bit is suppored if the SoC support the > blend_modes. > Make the constatnt alpha only enable when having a vliad blend_mode or > setting the has_alpha to fix the downgrade issue. > > Fixes: bc46eb5d5d77 ("drm/mediatek: Support DRM plane alpha in OVL") > Signed-off-by: Jason-JH.Lin > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 89b439dcf3a6..8453a72f9e59 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -473,8 +473,14 @@ void mtk_ovl_layer_config(struct device *dev, unsigned int idx, > > con = ovl_fmt_convert(ovl, fmt, blend_mode); > if (state->base.fb) { > - con |= OVL_CON_AEN; > con |= state->base.alpha & OVL_CON_ALPHA; > + > + /* > + * For blend_modes supported SoCs, always enable constant alpha. > + * For blend_modes unsupported SoCs, enable constant alpha when has_alpha is set. > + */ > + if (blend_mode || state->base.fb->format->has_alpha) > + con |= OVL_CON_AEN; I'd say that you should make sure that OVL_CON_AEN is not set when !blend_mode && !has_alpha, and you can do that like this: if (blend_mode || state->base.fb->format->has_alpha) con |= OVL_CON_AEN; else con &= ~OVL_CON_AEN; After applying the proposed change, Reviewed-by: AngeloGioacchino Del Regno