From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13F11313544 for ; Fri, 14 Nov 2025 11:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120664; cv=none; b=SzlOFjZHspce3d+KdnT0L/hRn/1Bu5URA5TN24aoNwj0elFhuHo9oRtuZkFDLBUw9ZfAR2vXvI2/62rNu4I34cVUu+XqDHDev0/pjxeocMyEfTJvU4lX10ukH9mmzkeH/+XwEFlOkqpXZbbsWlNXR014BlhGi6vIsfjnN049E04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763120664; c=relaxed/simple; bh=tXEhMTeobqWm2DspymUecp5j7xcjLvhHGj6wY5g7ZLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hqizzuWmZO8UN6KclnKfim8rGEqptZdcAhro77m8yoLlMyVX23WN8Swd9LaUhal9SHFUFoDmxVNoa0eqfwcK+ByhQ1ymL2UpVCU4Z5XsvGtn8wWdsp3kJG6dxBdFsRnBo9s1TNrb4C27r1UEtyu61vGVLI67ktzdX0M0Ou1LB5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VuFdSrrh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bqcyyqa7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VuFdSrrh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bqcyyqa7" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AE8LqCw1698664 for ; Fri, 14 Nov 2025 11:44:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5961PjEg1810kbw0j0eiHAeuJitJT7UlO8fvP1HU50A=; b=VuFdSrrhJeEzK3wb 83dIPl9p+5XQN0YyrqeaAKqvqZk+2YVebqGk157VzP9bMHQZCkcZ654KwQ4t02kS 7K8mIp4LSFk66284F7eZdLKNyrh2tnLsCeqrG4zcTUpOIn6wGzmhAa6+b/bHSPgD AZdhwAXNZNgD91T+045U3baj3di6VeHbXg0Vl97qu4KJCdueffgkvcRE+oBVDDlR efW4rX7fERRiE2WGCQTFkhXHyT+Ed0VaXQ9/OhKd3T9ITlp5GDEttm/N826Ei7Yk 7trkoIhYzPFEX+BfwowsGCCnW/40pqMhpjBa6g6Wz+WvxW44M8cmNnKjezADUj7P osSkTQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4adr9g20ux-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Nov 2025 11:44:21 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ed846ac283so69996951cf.0 for ; Fri, 14 Nov 2025 03:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763120661; x=1763725461; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5961PjEg1810kbw0j0eiHAeuJitJT7UlO8fvP1HU50A=; b=Bqcyyqa7OuEH3XXMO+IV6VIbeBmvfU3RFesXpKErMAPEn5BnEnmfqeIKYZ1czg+qg1 sQcKBSDHR8zxI9wArU1LQDzPMN1nstmfZ66OqqBZeR0Zm6Sw77FiLwZ68utiUC1nMMFL hH6EUJImY5+8DymTBXTZS8EA8THhZWpqrTk8Zw660Z0HqZY5RCEOiziGVypO6sd/ryIS YRrQhvP+o2lZzwdpxa8r8no7c+8dYmh+/XvixxfQWsco7BYGHZed0dzztVbfs3RO/7Nb iT1RSog2UK8D2icWJaabmqlrbX7nUh4JNcr+yN3+u50PRZ043pDnXiMrzuE8Yp5ccEZm e3rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763120661; x=1763725461; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5961PjEg1810kbw0j0eiHAeuJitJT7UlO8fvP1HU50A=; b=uXdkZlUdVrVdqIa4hU5erO87qOd2uSjvKQjH9VPV0r83Qie2sW4LQF4xJaGziBshpA XRskqeSlGqM3FPa0A9knwMy4SjT9szcHc3X/GQke0BrXdu+HYnQhP+DCHGeZ+mK/b9v4 SvMjN34FAt5DSzV66YSKICYGujj4c/zOx29W52KSU3LKE900kXjDRIFpi4gnHTviMCku hn4Pz9vwm0vCRn5sLfmY28hq9KmKcJTpz09IDsvqeoTSMSPeMSFZleuvdG3ZLGVEaa6n kNS0efGGzu6G3/C/RcrPjNdLfguDrrc/KG1Vmu1VWUCpe2geltsHwxynCHiDJkixAMGP oFaQ== X-Forwarded-Encrypted: i=1; AJvYcCW9mYDRxBgOw3h7OoMGlW+IE2FfDWI8iZQiyHps8BAl9sBPtgis/jaDQfl2IWW5rujPt5dblPm/D2uMO+0=@vger.kernel.org X-Gm-Message-State: AOJu0YxRcSxJRvt9LfvcnAMalir2e86nvNlq4UfLCzwTS2vQWhuv8f/v L5IDiUHGensT4YwtDFN6mDAYQY6MLk9Yy/rEvnWmyRI1h6s6XSKOBg29jl92MZnT+L3IsNH3wcD xRIJLRd8Hb4Ph2uEb63lxG3ex0Hg7+tQEpXU1mIel9dhFqwhx1oR9rx2yvYAgHnJpndA= X-Gm-Gg: ASbGncuYFvtJ1Htq4W6Ut5h0qfHZtH6Ptr1LwAm9wKVgi8KsxJjlDRu30Nny7MrjPqI BTDBHEAl3ONg9Nqurl47wF683+lBfCIWubsRvSK517aFgsvtsU5hmjv8gN1f+lS1n/oO/VbC5sS q83aD/UIRy6TYA+ztxo8H5M5FNuOJYhNwgRmK95uYDRZImGTDn7DvXHQkydJhb9a5lTfg9LIJn8 SAaGV9976LzfbL4s2nWKGCyi8OpjFiRd5ZfBS1fOEoPkO61a7GdwnIi6AWoyC13x/HvjrnvXiET 4JRHlOZvHkBwtwrvwdvoNpQNfPURJNR/GzeH/4RBe0EX+daxHjCZ3iQhkQxy4hiv0HZ0MOmY3ko O1ZMDtLwQ51UZ6W3OETf0vvtODJjxn6T4hlcG X-Received: by 2002:a05:622a:34b:b0:4ed:223e:139b with SMTP id d75a77b69052e-4ede6faa8e2mr91683591cf.6.1763120661264; Fri, 14 Nov 2025 03:44:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGKSxXof2g5+6sgV/vHp4xRjNtsZJyx2k6oEmSKoRXu7xN5sluEXzQ2X8pNO62GmUXl+lsLw== X-Received: by 2002:a05:622a:34b:b0:4ed:223e:139b with SMTP id d75a77b69052e-4ede6faa8e2mr91683351cf.6.1763120660805; Fri, 14 Nov 2025 03:44:20 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-477952b001csm2189845e9.16.2025.11.14.03.44.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 03:44:20 -0800 (PST) Message-ID: <70322e09-694a-471d-b4fc-f5a8a1c01450@oss.qualcomm.com> Date: Fri, 14 Nov 2025 11:44:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] wifi: ath: Use static calibration variant table for devicetree platforms To: Krzysztof Kozlowski , Manivannan Sadhasivam Cc: Jeff Johnson , Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, devicetree@vger.kernel.org, ath12k@lists.infradead.org, Miaoqing Pan References: <20251114-ath-variant-tbl-v1-0-a9adfc49e3f3@oss.qualcomm.com> <20251114-ath-variant-tbl-v1-1-a9adfc49e3f3@oss.qualcomm.com> <3a951821-14b1-464e-b1da-05a95f4164af@kernel.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 4udc_eY2e2xrdlWrTyE9y2d3CxfL37iV X-Proofpoint-ORIG-GUID: 4udc_eY2e2xrdlWrTyE9y2d3CxfL37iV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE0MDA5MyBTYWx0ZWRfX5BPAcmabxUNz uBKzwn0Zlf1I+DaEmxD5BJVEfRBY0paEOti3/TMAbeHg0M7uqhtRS28YA+rraHjt1nPecHFUMoW 1LXt4y1N6kQR9HjV9q7jj8gsxc34RKZ/c0icz51Vx1RpemniUJdJILXFxQIeEwiQrzv+N8WBG6I me6y79/HkS4bELoMt7DjVkE1XFI0nNM7DLnrTkB0A8T4gN5Kx3ZuslbTsBQv5vl6/BRSbtWNI/U 8EJOnZ/amT7S1GhagbQCcXfxwHM/eg18cTCPny/WaHr8RNMLk1mE6wXEStQPHLT2j3CHYFAxVMs TCt93LSiNfq8UTUl1R9qCJnCv+oyQ4sbw2GJBUBqbuWlb2QsQvU5o0M7uDKDbfa/ll2s/qoiSx2 IdtC3ECZRPbyiIcZh52jHm4AYOloJQ== X-Authority-Analysis: v=2.4 cv=IM8PywvG c=1 sm=1 tr=0 ts=69171615 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gHqtoCV0S4uQAjPoSdoA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-14_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511140093 On 11/14/25 11:24 AM, Krzysztof Kozlowski wrote: > On 14/11/2025 12:16, Manivannan Sadhasivam wrote: >>>> >>>> +static const struct __ath_calib_variant_table { >>>> + const char *machine; >>>> + const char *variant; >>>> +} ath_calib_variant_table[] = { >>>> + { "ALFA Network AP120C-AC", "ALFA-Network-AP120C-AC" }, >>>> + { "8devices Jalapeno", "8devices-Jalapeno" }, >>>> + { "Google cozmo board", "GO_COZMO" }, >>>> + { "Google damu board", "GO_DAMU" }, >>>> + { "Google fennel sku1 board", "GO_FENNEL" }, >>>> + { "Google fennel sku6 board", "GO_FENNEL" }, >>>> + { "Google fennel sku7 board", "GO_FENNEL" }, >>> >>> Are these top-machine models? If so, you cannot use them. The value is >>> user-informative, not ABI. If you wanted to use them, you would need to >>> document the ABI. the value has expected format, can it not be an ABI?, from DT Specs: "Specifies a string that uniquely identifies the model of the system board" We can argue that its not part of Documentation/devicetree/bindings/arm/qcom.yaml @Mani, can you not use the top level machine compatibles instead, something like: "google,fennel-sku7" instead of "Google fennel sku7 board" which is an ABI. >>> >> >> I had this question initially, but Srini convinced me it is OK to use it in the >> driver as they do it in audio :) > > That's sounds like an issue which could be fixed or at least discussed. > There is no in-kernel usage of ASoC's 'model' property, thus we probably > never noticed that it is an ABI. > model is actually used as soundcard name and long name if there is no DMI info for the platform, This string is also used at the UCM level to identify the correct UCM configuration. However the model that we are referring for sound is part of the dt-bindings for the sound card, not the top-level model, so this is an ABI for soundcard itself. --srini > OTOH, everyone apparently knows that audio's 'model' is an ABI because > no one changes it, unlike top-level machine 'model' which is being > changed from time to time. > > Best regards, > Krzysztof