mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrea Parri <parri.andrea@gmail.com>,
	Will Deacon <will.deacon@arm.com>,
	Boqun Feng <boqun.feng@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] memory-model: fix cheat sheet typo
Date: Wed, 11 Apr 2018 19:06:36 +0200	[thread overview]
Message-ID: <70348608-e695-1977-d34e-d7d66b07ad25@redhat.com> (raw)
In-Reply-To: <20180411163157.GQ4082@hirez.programming.kicks-ass.net>

On 11/04/2018 18:31, Peter Zijlstra wrote:
>>>                                    Prior Operation   Subsequent Operation
>>>                                    ---------------   ---------------------
>>>                                    R  W  RMW  SV     R  W  DR  DW  RMW  SV
>>>                                    -  -  ---  --     -  -  --  --  ---  --
>>> smp_store_mb()                     Y  Y    Y   Y      Y  Y   Y   Y   Y   Y
> I'm not sure about that, the generic version of that reads:
> 
> include/asm-generic/barrier.h:#define __smp_store_mb(var, value)
>     do { WRITE_ONCE(var, value); __smp_mb(); } while (0)
> 
> Which doesn't not have an smp_mb() before, so it doesn't actually order
> prior; or I'm failing to read the table wrong.

You're not, even better reason to document it. :)  I was going from
memory for the x86 version.

I'll start tomorrow on fixes to the current document, while we discuss
the split format and what to do about cumulativity and propagation.

Paolo

  reply	other threads:[~2018-04-11 17:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 16:50 Paolo Bonzini
2018-04-09 18:42 ` Paul E. McKenney
2018-04-10 20:32   ` Paul E. McKenney
2018-04-10 21:10     ` Paolo Bonzini
2018-04-10 21:34       ` Paul E. McKenney
2018-04-11 11:15         ` Paolo Bonzini
2018-04-11 16:19           ` Paul E. McKenney
2018-04-11 16:31             ` Peter Zijlstra
2018-04-11 17:06               ` Paolo Bonzini [this message]
2018-04-12 12:52                 ` Boqun Feng
2018-04-12  9:23           ` Andrea Parri
2018-04-12 10:18             ` Paolo Bonzini
2018-04-12 11:21               ` Andrea Parri
2018-04-12 21:18                 ` Paul E. McKenney
2018-04-13  9:54                   ` Andrea Parri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70348608-e695-1977-d34e-d7d66b07ad25@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=akiyks@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=j.alglave@ucl.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.maranget@inria.fr \
    --cc=npiggin@gmail.com \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=stern@rowland.harvard.edu \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®