Re: [PATCH 0/5] ACPI: acpi_bind_one()/acpi_unbind_one() cleanups

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday, August 06, 2013 03:15:36 PM Toshi Kani wrote:
> On Tue, 2013-08-06 at 02:22 +0200, Rafael J. Wysocki wrote:
> > Hi All,
> > 
> > The following 5 patches clean up a little mess in acpi_bind_one() and
> > acpi_unbind_one().  They are on top of current linux-next plus the patch
> > at https://patchwork.kernel.org/patch/2839101/ .
> > 
> > [1/5] Move duplicated code from acpi_bind_one()/acpi_unbind_one() to a separate
> >       function.
> 
> I think the name of acpi_bind_physnode_name() is a bit confusing as if
> it would make some persistent binding.  So, I'd suggest to rename it to
> acpi_set_physnode_name().

In fact, the plan was to make it mean "physical node name for acpi_bind", but
the execution was somewhat sloppy. ;-)

I think I'll call it acpi_physnode_link_name(), that should be clear enough.

> > [2/5] Create symlinks in acpi_bind_one() under physical_node_lock.
> > [3/5] Clean up inconsistent use of whitespace in acpi_bind_one()/acpi_unbind_one().
> > [4/5] Use list_for_each_entry() to walk the list in acpi_unbind_one().
> > [5/5] Clean up the error code path in acpi_unbind_one().
> 
> All changes look good.  For the series:
> 
> Acked-by: Toshi Kani <toshi.kani@hp.com>

Thanks!

Rafael