From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Artur Weber <aweber.kernel@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 0/2] ARM: dts: bcm-mobile: Split out nodes used by both BCM21664 and BCM23550
Date: Mon, 29 Jul 2024 15:07:12 -0700 [thread overview]
Message-ID: <70365646-ee0d-485f-b865-e0aaa304d758@broadcom.com> (raw)
In-Reply-To: <20240729-bcm21664-common-v2-0-ebc21a89bf63@gmail.com>
On 7/29/24 05:34, Artur Weber wrote:
> The BCM21664 and BCM23550 are nearly identical to each other in terms
> of register layout. This was verified against a downstream kernel[1] -
> Broadcom's kernel has "RDB" directories which includes headers with
> the full register maps for the included hardware. Running:
>
> diff --recursive arch/arm/mach-{hawaii,java}/include/mach/rdb
>
> reveals that the differences are minuscule - some things related to
> ISP and H264 decoding. Most of the other differences are related to
> the different CPUs in the two chipsets - the BCM21664 has 2x Cortex-A9
> cores, and the BCM23550 has 4x Cortex-A7 cores.
>
> In mainline, most drivers are also re-used between the two.
>
> To make development for both platforms easier, split out the common
> nodes into a separate DTSI, bcm2166x-common.dtsi. This only leaves
> the device-specific nodes - so, CPU and related things - in the SoC-
> specific DTSIs (bcm21664.dtsi and bcm23550.dtsi).
>
> The new DTSI is based off the bcm23550.dtsi, with its split into
> busses. Since it's pretty much 99% identical, I kept the licensing
> of the original file (BSD 3-clause). The license for the bcm21664.dtsi
> file remains GPL 2.0 as it originally was.
>
> make CHECK_DTBS=y on bcm21664-garnet.dtb and bcm23550-sparrow.dtb
> seem to pass fine for me (thanks to Stanislav Jakubek for converting
> the bindings to YAML format!).
>
> [1] https://github.com/knuxdroid/android_kernel_samsung_baffinlite
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Thanks for resending, I had those on my radar to push out, now done!
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next
--
Florian
prev parent reply other threads:[~2024-07-29 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 12:34 Artur Weber
2024-07-29 12:34 ` [PATCH RESEND v2 1/2] ARM: dts: broadcom: bcm21664: Move chosen node into Garnet DTS Artur Weber
2024-07-29 12:34 ` [PATCH RESEND v2 2/2] ARM: dts: bcm-mobile: Split out nodes used by both BCM21664 and BCM23550 Artur Weber
2024-07-29 22:07 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70365646-ee0d-485f-b865-e0aaa304d758@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®