From: Shawn Lin <shawn.lin@rock-chips.com>
To: cl@rock-chips.com
Cc: heiko@sntech.de, shawn.lin@rock-chips.com, robh+dt@kernel.org,
mark.rutland@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, shawnguo@kernel.org,
rocky.hao@rock-chips.com, afaerber@suse.de,
fabio.estevam@nxp.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, rjw@rjwysocki.net,
viresh.kumar@linaro.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 1/3] arm64: dts: rockchip: add mmc nodes for rk3328 evaluation board
Date: Wed, 23 Aug 2017 17:58:10 +0800 [thread overview]
Message-ID: <70373b2e-2b2f-215e-04e3-1559a00950f0@rock-chips.com> (raw)
In-Reply-To: <1503477632-9661-2-git-send-email-cl@rock-chips.com>
On 2017/8/23 16:40, cl@rock-chips.com wrote:
> From: Liang Chen <cl@rock-chips.com>
>
> Rockchip's rk3328 evaluation board has 3 mmc controllers for
> sdio/sdmmc/emmc, let's enable them.
>
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 74 +++++++++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
> index 86605ae..479f9d9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
> @@ -60,6 +60,20 @@
> regulator-max-microvolt = <12000000>;
> };
>
> + sdio_pwrseq: sdio-pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + pinctrl-names = "default";
> + pinctrl-0 = <&wifi_enable_h>;
> +
> + /*
> + * On the module itself this is one of these (depending
> + * on the actual card populated):
> + * - SDIO_RESET_L_WL_REG_ON
> + * - PDN (power down when low)
> + */
> + reset-gpios = <&gpio1 18 GPIO_ACTIVE_LOW>;
> + };
> +
> vcc_sys: vcc-sys {
> compatible = "regulator-fixed";
> regulator-name = "vcc_sys";
> @@ -69,6 +83,29 @@
> regulator-max-microvolt = <5000000>;
> vin-supply = <&dc_12v>;
> };
> +
> + vcc_sd: sdmmc-regulator {
> + compatible = "regulator-fixed";
> + gpio = <&gpio0 30 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc0m1_gpio>;
> + regulator-name = "vcc_sd";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vcc_io>;
> + };
> +};
> +
> +&emmc {
> + bus-width = <8>;
> + cap-mmc-highspeed;
> + supports-emmc;
> + disable-wp;
Please remove supports-{emmc,sd, sdio} for all mmc node.
And disable-wp is for SD *only*.
> + non-removable;
> + num-slots = <1>;
num-slots is deprecated.
> + pinctrl-names = "default";
> + pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
> + status = "okay";
> };
>
> &i2c1 {
> @@ -186,6 +223,43 @@
> rockchip,pins = <2 RK_PA6 RK_FUNC_GPIO &pcfg_pull_up>;
> };
> };
> +
> + sdio-pwrseq {
> + wifi_enable_h: wifi-enable-h {
> + rockchip,pins =
> + <1 18 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +};
> +
> +&sdio {
> + bus-width = <4>;
> + cap-sd-highspeed;
> + cap-sdio-irq;
> + disable-wp;
Ditto
> + keep-power-in-suspend;
> + max-frequency = <150000000>;
> + mmc-pwrseq = <&sdio_pwrseq>;
> + non-removable;
> + num-slots = <1>;
Ditto
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>;
> + supports-sdio;
Ditto
> + status = "okay";
> +};
> +
> +&sdmmc {
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
Ditto
> + disable-wp;
> + max-frequency = <150000000>;
> + num-slots = <1>;
Ditto
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc0_clk &sdmmc0_cmd &sdmmc0_dectn &sdmmc0_bus4>;
> + supports-sd;
Ditto
> + vmmc-supply = <&vcc_sd>;
> + status = "okay";
> };
>
> &tsadc {
>
next prev parent reply other threads:[~2017-08-23 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 8:40 [PATCH v1 0/3] Enable some devices " cl
2017-08-23 8:40 ` [PATCH v1 1/3] arm64: dts: rockchip: add mmc nodes " cl
2017-08-23 9:58 ` Shawn Lin [this message]
2017-08-23 8:40 ` [PATCH v1 2/3] cpufreq: rockchip: add support for rk3328 soc cl
2017-09-14 21:24 ` Viresh Kumar
2017-08-23 8:40 ` [PATCH v1 3/3] arm64: dts: rockchip: add cpu regulator for rk3328 evaluation board cl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70373b2e-2b2f-215e-04e3-1559a00950f0@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=afaerber@suse.de \
--cc=catalin.marinas@arm.com \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=rocky.hao@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®