From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B216942AA6 for ; Mon, 22 Dec 2025 11:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766404043; cv=none; b=SvdSE+f9HOblu+qkBe5WAqOEun2VM0UpPXjdPjhJPC1HNvbor1gQjLb7yks67+UA2ox0o0mvexmozK3JvfuTdHx4eT5dHnEChbjaFMLBL8dWpXzNHnUOpvfrTx15jIXJ30pr/bARO/QT2aqQOH2F8LRshMF2hkWwTZUBWZrWhCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766404043; c=relaxed/simple; bh=pyrrhaX/CQ8Yt1gGy1KhHavnV9uSnKcpHBeyLBp4GGU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T0X3gciqiJsGQLE/52j8Z5MjYWoPQe36p6pFKRTvT1UTPUJy4C92A3ZzOd+rWD+U6Qmjq12YkBCwIQnUBcbOq7ib1ek6yCTbR9kcqh5RblAjRoVjGk77vLhvpkVOJQVqmz/9pN8poukEYeGHPuHnIxGz8fuBKXq3KgjiWomjVR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jr/VnzAO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dTgNsR85; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jr/VnzAO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dTgNsR85" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BM9Yost1603486 for ; Mon, 22 Dec 2025 11:47:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1/UIKllkeGxfodWfrgyA3aDglaljYW2IF4b2+t1+pfE=; b=Jr/VnzAO7vEfcILA DKLS1Q6Ch74s1IoDPCbiQ+JRQGJxSLojulamGHNE1JBlMnsuWuwEWxMt24x0xAbH 7+emv1kpkGGDAafptGMs9IsoQ2D/KVMx5H7s9iPV5OMKwXW5jRfAWyvek2R0+mFm jgsMOpl6NDlIn7egIzyKiivvv8rNsRKmGrWpd+31wsSbAK3htvuIolwMtdMMXOAn eSqwWQdW08/T+WwQZSjz+jfhRvyw6ADHaJD8hiZZb4EwxPSPgGslTNgT0Qk5QwOW E/WtN0zkEDevHGtYwzQw+zZ0dJQ0ZInzA1OePw8QHHd/3DhyTC8twFSZerqexqjA DVtVOw== Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b73fwrbf6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 11:47:20 +0000 (GMT) Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-3ece92bc1b5so6870035fac.3 for ; Mon, 22 Dec 2025 03:47:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766404039; x=1767008839; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1/UIKllkeGxfodWfrgyA3aDglaljYW2IF4b2+t1+pfE=; b=dTgNsR85YpmFkbwehgZ/EhutzLXA+MAzdXhMDKv1S4HbdR1iYmPVUxivjJjLvJZIoJ 86gsU3fn/0vtwAbTCfSOB+0udK/I/8kFghGdPyBhSBK2tqTbf0eaUqbFUKwF70IhcECQ 7IZR499BYX+kRyahKrlbvDcCerToDmFViOBFyNJO/HSJXAQ9LtnSSuiMTfc9si5L5FsJ /XGRzGmJAMPX9yXpn5M/0B50uI/xlkEB1KUaUaxRUmfOCQGTF+ipClxIbUhsZ/GQCZrd coHxSmp8d0bteQ6vjIw7n5XbUuyWCruJvaeSHNIV66MIvDfunzN8IT7h61akNJesBFMC B51A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766404039; x=1767008839; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1/UIKllkeGxfodWfrgyA3aDglaljYW2IF4b2+t1+pfE=; b=dOV0IVcIpVr/+vSSSS0C46NbK2DaskufTAujCfYw9+TBAjXtZGcFdeK+aQC9SODJOA hI4h5RNwlX+WUqZ7YTG8Z1k5+bq7Dm6PB51m5eqTyQ7SkfxzNOg/ykxB6/7N5o8uUtSa ftP2nir9YGg+2fYKD+7lq3j79tmdlSzbbxpJtQIHHr8lNiNWZl+HPzczI2ymzza+skSY KT36pLNP01+7M8PI/a2oucz7BTiv8lh/F9Scr/b5iNawhlsXqeCnSbDfgqaUVYEISecD Fnw+s/YYITMplzSPuCTMNsnAfky2H2yF6l2f+24jYAy67eDA2rIk2w9ahKgb6SJUJvU2 d0Jw== X-Forwarded-Encrypted: i=1; AJvYcCVDyR/Ol8zmcZ2E4Ji9xM9teLRAsR0+q9Op/e8JZldYsM6tF65B/OjY7tkrfq6eWUHyeX2QdVuPOcxB6Kk=@vger.kernel.org X-Gm-Message-State: AOJu0YynVcMEcizYiYdbZRwmJ0PP4gHWTsQgB3FXjscxCfItFgMl5Y6p wL7+XtrqAZmM4aZTcSrLa026JEjY67HfJ6NErjwf6EC8fjQq8H1NnwNJ+0ILykNK6oPJojvx/x7 2YUmAZehoBce/myfKeRA/RckyN1i8heYQGBzV7XXOGvXnRbvOarLKPIIW8wKtSjyd8NHzmt4jEv 8= X-Gm-Gg: AY/fxX6MhwYFicbOmseBw2BRjPYYgV1A13w0sDjr4o4jPEIo3Je+9/rgUjjGXURjqhs NP1/lWFcnMFToneMF23C9H8TQ1xU0QyTDipi58pjyvwCotKxIuc+YFeObXtiQTry+8YeZ2c9v6S A6HszIYmyO1qQYq/jwUykazRFvFpRns9OLg3xTbruFhXzvzYWxhAMTc7waYZsaPlWKoXg5HGR/P 9oy+h4p/c5rcq4laoH9CPiZ95yqqYKqqSirNocZQ/o/tZcHcBdGDGFFbKeefx5EvxJ//QJkLvMN i3KQwd7RS/vkKBTPL1EaTOlhZfBpKMc0Vjkx3J+SGkWbja8hF55QB3XxzFelrBg0L027Nxa7dny H08IgkT2FG5TjmXeIY3hK4JH6MhCZsKQE6STfXQcVi41jyYipjflpxXMGDyW1AKYYn4IlHsG2 X-Received: by 2002:a05:6871:385c:b0:2b8:fab0:33c with SMTP id 586e51a60fabf-3fda52428bcmr6059992fac.23.1766404039631; Mon, 22 Dec 2025 03:47:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAza++v23oEt2IeKj7cYmSqi5vvDcYVw+GWG1+c7r0HzLdrAgIa03YWh75CHj/b9JMwdvaZg== X-Received: by 2002:a05:622a:14cb:b0:4e8:aff9:a7a8 with SMTP id d75a77b69052e-4f4abd8c667mr168637841cf.52.1766403689980; Mon, 22 Dec 2025 03:41:29 -0800 (PST) Received: from [10.38.247.176] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4ac549da1sm74420891cf.9.2025.12.22.03.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 03:41:29 -0800 (PST) Message-ID: <703a502c-883d-434a-8bcf-f785080f5102@oss.qualcomm.com> Date: Mon, 22 Dec 2025 19:41:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: talos-evk-camera: Add DT overlay To: Vladimir Zapolskiy , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20251222-sm6150_evk-v1-0-4d260a31c00d@oss.qualcomm.com> <20251222-sm6150_evk-v1-3-4d260a31c00d@oss.qualcomm.com> Content-Language: en-US From: Wenmeng Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ELgLElZC c=1 sm=1 tr=0 ts=69492fc8 cx=c_pps a=zPxD6eHSjdtQ/OcAcrOFGw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=db0P6ePePT7CMihELGIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=y8BKWJGFn5sdPF1Y92-H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDEwNiBTYWx0ZWRfX20IlYOoBNxwh GXdhpHPL0FqNgQLE1tf6IGlvf8XiMD3zL0/gq5umPQjGRD/5q8ugQFIrHIZO//l43ewzKeTy2q0 jFPLxLK38+FROk60F+Q1s6BmCP+f0e5AQ5BwNhwbQvLmPROsqZOp0/7WO+B5pK9aT2R2RtQWOE6 e3S8egqBPtahAQJNxEGezzGTWRgstOLn1EAh1OdZWz41ZFyzldCOTtojGAElI95VMvDnqvbr9NQ mBBbbV+9Os1PxlquB1saPOVBj4ZXSOeHRJfczNikUsyd4FHMu+0YDG4oFrB0cFOdTqWrCvK0Fvt JvxZtGLA6NNES3I2Ih7R8Njw7u9pYkN4j76d/Iq5VxWxu8uYXPdt/93Y4xgKlGR08mDrMDHz0Wz 0hUsHvuYAyOfkCLuKK/w6jx8FDPW51GTljzhqKuaii4zQvG0LdsiqQT67rcIXMLk9DEKM9W9A1B PbhmnCJqDoIqlyrtNIw== X-Proofpoint-GUID: Bff0cGTTeQyNvufop77iFNoVioBQppBr X-Proofpoint-ORIG-GUID: Bff0cGTTeQyNvufop77iFNoVioBQppBr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220106 On 12/22/2025 7:19 PM, Vladimir Zapolskiy wrote: > On 12/22/25 10:44, Wenmeng Liu wrote: >> Enable IMX577 via CCI on Taloss EVK Core Kit. >> >> The Talos EVK board does not include a camera sensor >> by default, this overlay reflects the possibility of >> attaching an optional camera sensor. >> For this reason, the camera sensor configuration is >> placed in talos-evk-camera.dtso, rather than >> modifying the base talos-evk.dts. >> >> Signed-off-by: Wenmeng Liu >> --- >>   arch/arm64/boot/dts/qcom/Makefile              |  2 + >>   arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 64 ++++++++++++++++ >> ++++++++++ >>   arch/arm64/boot/dts/qcom/talos.dtsi            | 21 +++++++++ > > Please split QCS615 MCLK definitions change into a separate commit. ACK.> >>   3 files changed, 87 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/ >> qcom/Makefile >> index >> 60121f133078b2754f98e6f45a3db4031b478cc8..b1d85b1f4a94714f2a5c976d162482d70ae920f2 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -325,7 +325,9 @@ dtb-$(CONFIG_ARCH_QCOM)    += sm8650-qrd.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8750-mtp.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8750-qrd.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += talos-evk.dtb >> +talos-evk-camera-dtbs        := talos-evk.dtb talos-evk-camera.dtbo >>   talos-evk-lvds-auo,g133han01-dtbs    := talos-evk.dtb talos-evk- >> lvds-auo,g133han01.dtbo >> +dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-camera.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-lvds-auo,g133han01.dtb >>   x1e001de-devkit-el2-dtbs    := x1e001de-devkit.dtb x1-el2.dtbo >>   dtb-$(CONFIG_ARCH_QCOM)    += x1e001de-devkit.dtb x1e001de-devkit- >> el2.dtb >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso b/arch/ >> arm64/boot/dts/qcom/talos-evk-camera.dtso >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..ae1a02295b4dc48212aad40980a329ff458fe69a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso >> @@ -0,0 +1,64 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > > Please add a missing year of the change. Now our requirement is a yearless copyright.> >> + */ >> + >> +/dts-v1/; >> +/plugin/; >> + >> +#include >> +#include >> + >> +&camss { >> +    vdd-csiphy-1p2-supply = <&vreg_l11a>; >> +    vdd-csiphy-1p8-supply = <&vreg_l12a>; >> + >> +    status = "okay"; >> + >> +    ports { >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> + >> +        port@1 { >> +            reg = <1>; >> + >> +            csiphy1_ep: endpoint { >> +                clock-lanes = <7>; > > Please remove 'clock-lanes' property. ACK.> >> +                data-lanes = <0 1 2 3>; >> +                remote-endpoint = <&imx577_ep1>; >> +            }; >> +        }; >> +    }; >> +}; >> + >> +&cci { >> +    status = "okay"; >> +}; >> + >> +&cci_i2c1 { >> +    #address-cells = <1>; >> +    #size-cells = <0>; >> + >> +    camera@1a { >> +        compatible = "sony,imx577"; >> +        reg = <0x1a>; >> + >> +        reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>; >> +        pinctrl-0 = <&cam2_default>; >> +        pinctrl-names = "default"; >> + >> +        clocks = <&camcc CAM_CC_MCLK2_CLK>; >> +        assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>; >> +        assigned-clock-rates = <24000000>; >> + >> +        avdd-supply = <&vreg_s4a>; > > Just one voltage supply? yes, 22pin camera module only have one pin for power.> >> + >> +        port { >> +            imx577_ep1: endpoint { >> +                link-frequencies = /bits/ 64 <600000000>; >> +                data-lanes = <1 2 3 4>; >> +                remote-endpoint = <&csiphy1_ep>; >> +            }; >> +        }; >> +    }; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/ >> dts/qcom/talos.dtsi >> index >> ebb1807f0222c075d4207163ed4359a55616d903..3626312f138f2e8f1888eb6aa43fa474cdee884f 100644 >> --- a/arch/arm64/boot/dts/qcom/talos.dtsi >> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi >> @@ -1550,6 +1550,27 @@ tlmm: pinctrl@3100000 { >>               #interrupt-cells = <2>; >>               wakeup-parent = <&pdc>; >> +            cam0_default: cam0-default-state { >> +                pins = "gpio28"; >> +                function = "cam_mclk"; >> +                drive-strength = <2>; >> +                bias-disable; >> +            }; >> + >> +            cam1_default: cam1-default-state { >> +                pins = "gpio29"; >> +                function = "cam_mclk"; >> +                drive-strength = <2>; >> +                bias-disable; >> +            }; >> + >> +            cam2_default: cam2-default-state { >> +                pins = "gpio30"; >> +                function = "cam_mclk"; >> +                drive-strength = <2>; >> +                bias-disable; >> +            }; >> + > > Please add to the list another pad with MCLK function, which is GPIO31. ACK.> >>               cci_default: cci0-default-state { >>                   cci_i2c0_default: cci-i2c0-default-pins { >>                       /* SDA, SCL */ >> > will update in next version. Thanks, Wenmeng