Re: [PATCH v2 2/7] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 5/8/25 6:31 PM, Prasad Kumpatla wrote:
> 
> 
> On 4/29/2025 4:21 PM, Konrad Dybcio wrote:
>> On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
>>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>>
>>> Add WSA LPASS macro Codec along with SoundWire controller.
>>>
>>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>>> ---

[...]

>>> +        swr2: soundwire@3250000 {
>>> +            compatible = "qcom,soundwire-v1.6.0";
>>> +            reg = <0x0 0x03250000 0x0 0x2000>;
>>> +
>>> +            interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
>>> +            clocks = <&lpass_wsa_macro>;
>>> +            clock-names = "iface";
>>> +
>>> +            resets = <&lpass_audiocc LPASS_AUDIO_SWR_WSA_CGCR>;
>>> +            reset-names = "swr_audio_cgcr";
>>> +
>>> +            qcom,din-ports = <2>;
>>
>> The computer tells me it should be 3
> For swr2 - soundwire version-V1.6.0 contains din-ports as 2 only. Please refer below link
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi#n2931

I'm referring to what I've seen in the internal data as parameters,
please doublecheck

Konrad