From: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Abel Vesa <abel.vesa@linaro.org>,
Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Subject: Re: [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle
Date: Tue, 10 Mar 2026 09:45:45 +0530 [thread overview]
Message-ID: <704b2d33-102e-74d0-781a-a9c7475ab0f2@oss.qualcomm.com> (raw)
In-Reply-To: <20260307-llama-of-massive-downpour-2e512a@quoll>
On 3/7/2026 4:06 PM, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 03:03:30PM +0530, Neeraj Soni wrote:
>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
>> So add the qcom,ice property to reference it.
>>
>> To avoid double-modeling, when qcom,ice is present, disallow an embedded ICE
>
> Can you finally fix checkpatch warning? I have impression you ignore
> checkpatch in each posting.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
Sure I will fix this in next patch.
>> register region in the SDHCI node. Older SoCs without ICE remain valid as
>> no additional requirement is imposed.
>
> With this fixed
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Best regards,
> Krzysztof
>
Regards
Neeraj
next prev parent reply other threads:[~2026-03-10 4:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:33 [PATCH v5 0/3] Enable Inline crypto engine for kodiak and monaco Neeraj Soni
2026-03-06 9:33 ` [PATCH v5 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle Neeraj Soni
2026-03-07 10:36 ` Krzysztof Kozlowski
2026-03-10 4:15 ` Neeraj Soni [this message]
2026-03-06 9:33 ` [PATCH v5 2/3] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC Neeraj Soni
2026-03-06 9:33 ` [PATCH v5 3/3] arm64: dts: qcom: monaco: " Neeraj Soni
2026-03-07 10:37 ` Krzysztof Kozlowski
2026-03-10 4:23 ` Neeraj Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=704b2d33-102e-74d0-781a-a9c7475ab0f2@oss.qualcomm.com \
--to=neeraj.soni@oss.qualcomm.com \
--cc=abel.vesa@linaro.org \
--cc=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®