From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC2AD567A; Mon, 19 Feb 2024 02:28:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708309741; cv=none; b=bdZky01QnI9PlSyfVpjkdMhJtH667+E+iZExyG5V+VLAMV7CkgTvq0p99IA9SJw9rIOHTM32i/cDXIrsrJeiJmdPIP//npivzPz4j7G8RiGR/rsJESMXuRnonp1X+fweFbVJONMsSG55E7xgNPr881fmE5ILfMUugLlsVU6D1AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708309741; c=relaxed/simple; bh=TsaSIS6QnLGBeoIalYs8GT6JIpYn03oOeXDpHnnr4tI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=RcVUeNu60XCDLO/+hkuYqpi9YbiZglt/X9zrAEvLuCd58rrblnq1m8NCs0icZCc5McdEEPmOcIu3/LfCnyioJ+wm2tQAjkoVoa661FczNtzyKDREWt2EOA4eFLkDBCvdZIpuGTMD2/pLOA9iUlBMPeQK3Zpb1oorSzqyn0iEdqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=hisilicon.com; spf=pass smtp.mailfrom=hisilicon.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=hisilicon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hisilicon.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TdRJj4g0Kz1xmf9; Mon, 19 Feb 2024 10:27:33 +0800 (CST) Received: from kwepemi500006.china.huawei.com (unknown [7.221.188.68]) by mail.maildlp.com (Postfix) with ESMTPS id B52FF14011D; Mon, 19 Feb 2024 10:28:53 +0800 (CST) Received: from [10.67.120.168] (10.67.120.168) by kwepemi500006.china.huawei.com (7.221.188.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 19 Feb 2024 10:28:53 +0800 Message-ID: <70518ac9-177a-520a-8a01-1f428592e182@hisilicon.com> Date: Mon, 19 Feb 2024 10:28:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH for-next 0/2] RDMA/hns: Support configuring congestion control algorithm with QP granularity To: Leon Romanovsky CC: , , , References: <20240207032910.3959426-1-huangjunxian6@hisilicon.com> <20240207083338.GB56027@unreal> <322ab57d-05d8-72b9-9580-0579b5d8b468@hisilicon.com> <20240208081025.GD56027@unreal> Content-Language: en-US From: Junxian Huang In-Reply-To: <20240208081025.GD56027@unreal> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500006.china.huawei.com (7.221.188.68) On 2024/2/8 16:10, Leon Romanovsky wrote: > On Wed, Feb 07, 2024 at 04:59:56PM +0800, Junxian Huang wrote: >> >> >> On 2024/2/7 16:33, Leon Romanovsky wrote: >>> On Wed, Feb 07, 2024 at 11:29:08AM +0800, Junxian Huang wrote: >>>> Patch #1 reverts a previous bugfix that was intended to add restriction >>>> to congestion control algorithm for UD but mistakenly introduced other >>>> problem. >>> >>> First patch shouldn't be revert but a fix to "add a restriction that only DCQCN >>> is supported for UD." and second patch should be a new feature. >>> >>> Thanks >>> >> >> OK, but I have two questions here: >> >> 1. Of course we can not only revert but also completely fix the bug in patch #1. >> But since we are adding a new feature that can also fix this bug in patch #2, >> the fix in patch #1 will be immediately removed in patch #2. Is this acceptable? > > I would expect that second patch will extend the first one and not remove. > >> >> 2. Should I still put these two patches into one patchset in the next version, or >> seperate them into two individual patchset? > > Better to separate, as we will take fix faster than new feature. > > Thanks > Sorry for the late reply. Will separate and re-send the fix first. Please ignore the v2 of this series. Thanks, Junxian >> >> Thanks, >> Junxian >> >>>> >>>> Patch #2 adds support for configuring congestion control algorithm with >>>> QP granularity. The algorithm restriction for UD is added in this patch. >>>> >>>> Junxian Huang (1): >>>> RDMA/hns: Support configuring congestion control algorithm with QP >>>> granularity >>>> >>>> Luoyouming (1): >>>> Revert "RDMA/hns: The UD mode can only be configured with DCQCN" >>>> >>>> drivers/infiniband/hw/hns/hns_roce_device.h | 26 +++++--- >>>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 18 ++---- >>>> drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 3 +- >>>> drivers/infiniband/hw/hns/hns_roce_main.c | 3 + >>>> drivers/infiniband/hw/hns/hns_roce_qp.c | 71 +++++++++++++++++++++ >>>> include/uapi/rdma/hns-abi.h | 17 +++++ >>>> 6 files changed, 118 insertions(+), 20 deletions(-) >>>> >>>> -- >>>> 2.30.0 >>>> >>>