mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: thunder.leizhen@huaweicloud.com,
	Stephen Smalley <stephen.smalley.work@gmail.com>,
	Ondrej Mosnacek <omosnace@redhat.com>,
	selinux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	Nick Kralevich <nnk@google.com>,
	Jeff Vander Stoep <jeffv@google.com>
Subject: Re: [PATCH 1/1] selinux: add the processing of the failure of  avc_add_xperms_decision()
Date: Wed, 07 Aug 2024 15:14:35 -0400	[thread overview]
Message-ID: <7063e0206fb6100d94114db6f8a0c538@paul-moore.com> (raw)
In-Reply-To: <20240807090057.1334-1-thunder.leizhen@huaweicloud.com>

On Aug  7, 2024 thunder.leizhen@huaweicloud.com wrote:
> 
> When avc_add_xperms_decision() fails, the information recorded by the new
> avc node is incomplete. In this case, the new avc node should be released
> instead of replacing the old avc node.
> 
> Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
> Suggested-by: Stephen Smalley <stephen.smalley.work@gmail.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
> ---
>  security/selinux/avc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Thanks, this looks good to me.  I'm going to merge this into
selinux/stable-6.11 with the idea of sending it, and your other
patch, up to Linus tomorrow, or potentially next week.

Thanks for your help!

--
paul-moore.com

      parent reply	other threads:[~2024-08-07 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  9:00 thunder.leizhen
2024-08-07 14:36 ` Stephen Smalley
2024-08-07 19:14 ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7063e0206fb6100d94114db6f8a0c538@paul-moore.com \
    --to=paul@paul-moore.com \
    --cc=jeffv@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nnk@google.com \
    --cc=omosnace@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=thunder.leizhen@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®