mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ho Jie Feng <hjf3108@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Luka Gejak" <luka.gejak@linux.dev>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"Hans Ulli Kroll" <linux@ulli-kroll.de>,
	Kalle Valo <kvalo@kernel.org>, neo_jou <neo_jou@realtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v4] wifi: rtw88: usb: don't report the aggregation buffer as a frame
Date: Mon, 2 Nov 2026 03:36:02 +0000	[thread overview]
Message-ID: <7065bd99615f46c59171e0fe1672f3a1@realtek.com> (raw)
In-Reply-To: <20261102033244.9330-1-hjf3108@gmail.com>

Ho Jie Feng <hjf3108@gmail.com> wrote:
> When rtw_usb_tx_agg_skb() has more than one frame queued, it copies them
> into a new buffer. That buffer was also handed to mac80211, as one
> additional TX completion.
> 
> Report TX status only for the original frames, and free the aggregate
> buffer without passing it to mac80211.
> 
> In the case the ieee80211_purge_tx_queue is called, the frame is
> passed to ieee80211_report_used_skb. Since it fulfills none of the
> conditions within the function, the frame is freed as normal without
> a TX status in that case too

Miss a period. I'll add it while getting merged. 

> 
> Fixes: a82dfd33d123 ("wifi: rtw88: Add common USB chip support")
> Signed-off-by: Ho Jie Feng <hjf3108@gmail.com>
> Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>



  reply	other threads:[~2026-11-02  3:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  3:32 Ho Jie Feng
2026-11-02  3:36 ` Ping-Ke Shih [this message]
2026-11-02  3:47   ` Jie Feng
  -- strict thread matches above, loose matches on Subject: below --
2026-11-02  3:24 Ho Jie Feng
2026-11-02  3:30 ` Jie Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7065bd99615f46c59171e0fe1672f3a1@realtek.com \
    --to=pkshih@realtek.com \
    --cc=hjf3108@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@ulli-kroll.de \
    --cc=luka.gejak@linux.dev \
    --cc=neo_jou@realtek.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®