Re: [PATCH v6 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC

["Sven Peter" <sven@svenpeter.dev>]

Hi Sebastian,

On Thu, May 22, 2025, at 15:06, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 15, 2025 at 06:21:19AM +0000, Sven Peter via B4 Relay wrote:
>> From: Hector Martin <marcan@marcan.st>
>> 
>> This driver implements the reboot/shutdown support exposed by the SMC
>> on Apple Silicon machines, such as Apple M1 Macs.
>> 

[...]

>> +
>> +static int macsmc_reboot_probe(struct platform_device *pdev)
>> +{
>> +	struct apple_smc *smc = dev_get_drvdata(pdev->dev.parent);
>> +	struct macsmc_reboot *reboot;
>> +	int ret, i;
>> +
>> +	/* Ignore devices without this functionality */
>> +	if (!apple_smc_key_exists(smc, SMC_KEY(MBSE)))
>> +		return -ENODEV;
>
> Is that a leftover? I would expect that you do not have the
> 'apple,smc-reboot' sub-device described in DT for such a case.

Yup, that's another leftover, will remove it for v7 as well.

>
> Otherwise
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>


Thanks for the review!


Sven