From: Markus Elfring <Markus.Elfring@web.de>
To: Karina Yankevich <k.yankevich@omp.ru>,
linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org,
lvc-project@linuxtesting.org,
Corentin Labbe <clabbe@baylibre.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] crypto: rockchip - drop redundant crypto_skcipher_ivsize() calls
Date: Wed, 5 Nov 2025 17:55:56 +0100 [thread overview]
Message-ID: <70685d39-9fc4-4e1d-a6a6-bd82cac9b007@web.de> (raw)
In-Reply-To: <20251105145204.2888978-1-k.yankevich@omp.ru>
> The function already initialized the ivsize variable
> at the point of declaration, let's use it instead of
> calling crypto_skcipher_ivsize() extra couple times.
…
* You may occasionally put more than 52 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc4#n658
* How do you think about to reduce the scope for such a local variable?
Regards,
Markus
next prev parent reply other threads:[~2025-11-05 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 14:52 Karina Yankevich
2025-11-05 16:55 ` Markus Elfring [this message]
2025-11-14 10:20 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70685d39-9fc4-4e1d-a6a6-bd82cac9b007@web.de \
--to=markus.elfring@web.de \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=k.yankevich@omp.ru \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lvc-project@linuxtesting.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®