From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C41AF3EC827; Wed, 30 Sep 2026 10:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790763305; cv=none; b=TT8jZ/JoBcrAvIFDl/YEM0U00aRr+ET5yjwAEf7BoCNpBWuYJjcTVClakkXfVFSawjuuJpKLcD9A4Y5AODQ35GrwS/ntlBuZY/G5e4oTBLRaFK3Vi4XbG1VLIfe+YX00eYKJpYrK1k7Hp0cAhrp3Hzy/9nan6DInrcczFT0bhUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790763305; c=relaxed/simple; bh=YnX8T7gNfbhjxb0T3bPJtC5F74MskXCpLp0g/w+uC24=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tou+C4h1DL5oVTwjo6zmZ1wKmjpMMn9lmFskun0CWBdt0fcLir9CiJBnPHA55noD/89Opgasu8PYHqQ8LMKzRn+sYxps4S3sd741wl9ejVX0ua3mjpM24gtYICVMxitMXfxmkmVuyVHY+odfh36bm6ZTCxJONGpg9RrkPbxD0Z4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=aZGZGfJG; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="aZGZGfJG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=YnX8T7gNfbhjxb0T3bPJtC5F74MskXCpLp0g/w+uC24=; b=aZGZGfJGrtsB20BtlHvOPFQKSe AZVuyaf4pho61ToIbowX2dFtcUR1oOw8x7uPdS14NJadzDDQ2RLI69MhxozNFa1H4KsLGCx8j55Q3 dMhTWz1qQTyilGbZZPovjP9NLeuLpRHDeI/8xmfvrD85DXGbXfChVP30VXyK0J6q3aA/gpMWZeLj5 fHO6cXX6d32eZ8cyOVsKMB0/6LBq9lD19lVRLXTT9RebJUybRmZV0Tf/SCokesG1QZsavYz4AqY43 MgRXkJdKSjJ9IUdwOzH2f9FhaEksRgk6PswKV+l7pnz/7VyAAO3LlNHjkC4gSXpdwgEPUgFaR+Bm+ oPVV8jjg==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Vinod Koul , Manivannan Sadhasivam , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , Michal Wilczynski Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Icenowy Zheng , Chaoyi Chen , Joshua Peisach , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Michal Wilczynski Subject: Re: [PATCH v5 18/21] phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers Date: Wed, 30 Sep 2026 12:14:31 +0200 Message-ID: <7069377.kQq0lBPeGt@diego> In-Reply-To: <20260929-jh7110-clean-send-v5-18-82b4d8e3c6c7@samsung.com> References: <20260929-jh7110-clean-send-v5-0-82b4d8e3c6c7@samsung.com> <20260929-jh7110-clean-send-v5-18-82b4d8e3c6c7@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Dienstag, 29. September 2026, 12:31:15 Mitteleurop=C3=A4ische Sommerzeit= schrieb Michal Wilczynski: > The RK3328 pre-PLL programming, its table lookup and its recalc_rate and > determine_rate implementations are the generic Innosilicon ones, so drop > the local copies and use the shared helpers instead. >=20 > The RK3228 pre-PLL sits at different register addresses, so it keeps its > own register level code and only shares the table lookup. >=20 > The now unused RK3328 pre-PLL register macros go with it, as does the > local pre-PLL config lookup wrapper; both call sites already have the > TMDS clock to hand and call inno_hdmi_phy_pre_pll_lookup() directly. >=20 > The RK3328 recalc_rate used to log the pre-PLL output as "vco". The > shared helper logs it too, and reports the actual VCO frequency > alongside the rate, which is the value with the 1.4-3.2 GHz constraint. >=20 > The register writes, their order and the values written are unchanged. > No functional change intended. >=20 > Signed-off-by: Michal Wilczynski > Reviewed-by: Chaoyi Chen Reviewed-by: Heiko Stuebner Only thing I cannot really make up my mind about, is if this and the previous patch should be merged ("move common code from rockchip variant to shared helper"). As I said, can't really decide what would be the better solution ;-) . Heiko