From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193AbdEaNiE (ORCPT ); Wed, 31 May 2017 09:38:04 -0400 Received: from mail-cys01nam02on0048.outbound.protection.outlook.com ([104.47.37.48]:10367 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750916AbdEaNh7 (ORCPT ); Wed, 31 May 2017 09:37:59 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption To: Borislav Petkov CC: , , , , , , , , , , Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> <20170418212223.10190.85121.stgit@tlendack-t1.amdoffice.net> <20170519112703.voajtn4t7uy6nwa3@pd.tnic> <7c522f65-c5c8-9362-e1eb-d0765e3ea6c9@amd.com> <20170530145459.tyuy6veqxnrqkhgw@pd.tnic> <115ca39d-6ae7-f603-a415-ead7c4e8193d@amd.com> <20170531084923.mmlpefxfx53f3okp@pd.tnic> From: Tom Lendacky Message-ID: <706d6ae0-bc4c-5ba7-529c-b0fc5e4ad464@amd.com> Date: Wed, 31 May 2017 08:37:50 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170531084923.mmlpefxfx53f3okp@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR18CA0022.namprd18.prod.outlook.com (10.175.218.160) To MWHPR12MB1150.namprd12.prod.outlook.com (10.169.204.14) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR12MB1150: X-MS-Office365-Filtering-Correlation-Id: 0f70f98b-3483-4134-7f82-08d4a82a3e89 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:MWHPR12MB1150; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;3:9ZCGVWGpnb+mFcRZvaM4NYMZwZFX0AskujcCK8RPvv5DF0H+oU5H+1Iw71J2Q2SR4VpmVRcm3FIbvN3eekn35sx0bKoXCFX+VMpyzkzsYAnaQSAOpbEWINN/dqvqfLJqqVXTRQD4VwkSdumQer8FjNnfqXlALxp2InGbungI3g6Ia19C9lvA0mGS/fn4Yzqee32rt1n6ctDR/uQWVSorJIGSNbdVFJcRvLJ7r51n6LeU47Il74yBMs8sYDNleMVH3khfK6J9tTonnx84lfg8uiiOnM11fPSmUUZrOzsLOgdrl3zQj6WtygtNAW0Yg/X/52sm+Q5tPCOUGGRa2eGL1hoXlGkPmfjWmDy71pv3krc=;25:CMg95oF4+83H3Ce3sybAljkAEsUzUzenGxvyScB+Djn48uUR763gSqK3BTMBH19qxmo56VeNXQb+oX3uQbxG6sMMVK4LWN34gcsohb2Wj/TxLlZZhgHaavam0CvhU/iFrnbH0MvNWt3o1UrYvPXQjW1kqD56TURmCtJheVG/c6K3DS7F2/MWdldxudnBxhk88Z24AvH3Bl968yqrMHJV+NOvAVA+0qdeMVIoAxhWrLVALN9sB0i+q1nbOFJCez2fddxLb7POy60Kp1M4dVRBlGSOPIfYgWG7QvNLKvYTCj36AGg9yqqD6sGfQlEMceS3KMPUC5vtz+gn51LsM2+HqWMErDWCMytNFOK4gFxZDb2wcI8kA8pbpL5lSBSFOsyB7e6ql9kTsBR3PXrmgabPzdKnFOIIZJSSr3ETzpvRpvr/1k4JtKBnNASeJCH5I1B1bcv5KltnWe60hrwZKQzAPi8Wrcbq9UG+ZJpzBUXUpac= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;31:aKuklrqShtH/HZqQRZsBvxIOxAh57gmTQeoBMGFWTlm73QSJVMDKLhw9rdIJqRAm3t1yg3r7YdERyMx7fGAMfd/UhN/UVxa8aaYwy7zB4KW8U8nZY2D03w5Ow3TVsR/roDmoNegOFQruuBcrX+Cx6/KxgVp/EN5f9jS2KkoADbI3VtGKJ0JCO3DAFbSqOE7nGKve8sYzFjsIpD5watdPZr0aUiLAiH5YogU8D/CdytI=;20:CIRKgBMmLq2OzMHUGg8MqNglmgCAktHFBXWEolWMkHhcbbfg50QCEnhEsHW2195VWqdtBIkT93/hAGbY5Nl9+DX+wkfNVfs5//o/VlJ6yrp7NIMTuXbMGue6E3CKE/6yrS/uReUFI2jCD3cBwKMeXMj5QWvuAaD3K4SzeWUDAjONNs4+wcOwzkLs28mI4YP9RIH8gA+BK2+zFbjDpF3Rl3JtiQFOw9n+qhh8PFmhs6FkBWnMZBh9+Jb6gGGHHmfZ5fPvt6DiRWfZj3v6QvFamw0xzNZrXzMr1Y7Cjg9hQ5glEAzMHxA/BHiDN2Yloto59iH0JiMS5oIUFrGR9lrjKHbwA7diWMY57YOkR7MHZGzy2sCEh9J2m9kNdws4x7MF1K50o7AOQCX8IvcQ2OoNa+S+vZtiRwxvEawTdphbeW6UilOsxhe3n2X4NfuruiWx6ctgHxWnd3uOh9u1ype13mr6Z0X6NYVrDuHHUrhJH/oE91BkZZZ5LktW02S/SUgH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703073)(100105400095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123558100)(20161123562025)(6072148)(100000704073)(100105200095)(100000705073)(100105500095);SRVR:MWHPR12MB1150;BCL:0;PCL:0;RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(100000804073)(100110200095)(100000805073)(100110500095);SRVR:MWHPR12MB1150; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUwOzQ6YWpCSm9oMHpha1pLN2xudEJMRGdGeXdSTW9j?= =?utf-8?B?OGtWNHZVMWgxeDBuMTdydjcvT3hxajBBcFZUSjFZNHJMdVduRkpMaHNBa2ZD?= =?utf-8?B?Mms5RFNHc2ZGTk9UWlZOZmpKUXI4ZjRMVllJZEhEQ1FUQUpaSmNGWmNCZVpz?= =?utf-8?B?YTl6WmsrNEVKc1NvQlhIYWVJZlVQVko4aG9kQVMwajM5U0VwcSs2Y3QvcnhX?= =?utf-8?B?WERWa2c2cWtLOXlzUVVQZFJ6ZmFZN3lsK0JwaUttZ09GRG51d2VBWHZ1VmxK?= =?utf-8?B?VnpOMkVxV21kSTUzWXJodTVrYUVsbDJHV3doWGVjK2Y0eHNlVy9qMkhqaU9q?= =?utf-8?B?NlBXZlBzMndtSlhKazZGb1FQa2ZTWFRkdVpINzV2ZUhCaFZ4elliWkZ1Q2Fw?= =?utf-8?B?OS9PdERwVjdrMCtsTHM2ZG92L1cxTWtyQitlWnlvc0hVTjhJOTN5YUZObHdx?= =?utf-8?B?eTFtd0I4Yjd4MnFuYVR0dkwrd3R6QU9uQzVKNmpmRGI0UE5LVzFabTJYUEpP?= =?utf-8?B?dFpMNjF6c1J2SGdhclUwMXRUR25ROGJCTFgvVWh3RWI4ZmE1VjVPRjdHWktq?= =?utf-8?B?TFZFOTd5K2xQNUQ4SHczeWZ2bjhhd1dSNTBIR1RMNjRYZitIOXkyVjNhSmtm?= =?utf-8?B?RmFCMVdEOGhEY092bis5bXU4bFZLRlFtM1ZDUndTcGdieGlWMzlaNGlqNnUw?= =?utf-8?B?a1BaTTFVSzRCQ3puOUx0Q0htMW9vcHI1SXlHemhudytpV25DZGhQY3JtWVZn?= =?utf-8?B?KzJDV201enB2NDZvb0lFTG5scVJwSDJ2WlpZekNqc016WDI5anVNME9NczFQ?= =?utf-8?B?MjBvMm9wS1lpQmpPOWtDM1BSRG5ldUJkMjZGN3lxdmxyaERmUi9TN0lBYVJR?= =?utf-8?B?bjE5SEY2K2Qvay9ob040UjMvaTlQbHhQRmFmeHg2cklLUDFoMHRIdGxybTN4?= =?utf-8?B?UGtUbE0rSWFlTExPMGFieWJ4ZjRlL3cvUzl0a1NXUCtvTWtMdVhFbXlrUTc3?= =?utf-8?B?K0lsaWI5VUJ0QXVBMVd0T3NvZVNKTk9Nc2VXSTEyZTV0Z2JDcFVEZzYrdWpj?= =?utf-8?B?ZVFFY1d3TitDUVVEZ2ZtQldPdGUrdWs4UCt2YktRbXhpNXYvbzJSK2E3eFk4?= =?utf-8?B?VGVpK3laMG02S2RRZGdZcnByb1ZOd2UvbzhIOWZkSThCZTlGRGJUUVUxZGJa?= =?utf-8?B?VWZlcElWc1hOay9kVDNDUWViMUllZDR4VFVwVXVMN0grMjJLUUpzU3BrMURL?= =?utf-8?B?R2xLdnVKbVpjUVRTQzBXRTgyZ2kxa2lUOC84Z3R5cXorRFZlY0RjUCtZNkhx?= =?utf-8?B?a0plWmhIc1hncmRwQTlOZWtGTWpBVmhiMFFVdHlRbUFtK2RGdytoQlE3VWJt?= =?utf-8?B?MDFTWVJvZDNiZUhldGJQQWxmcHF1Zkpjcy9CUWM4YmQ2M3diS1luLzJVNVk1?= =?utf-8?B?a3RLQVNhQzJ0MTREWkRPTXlwK1l1QlJhSXRhV1BBSFJjQkMrNVhOWFJGUVdV?= =?utf-8?B?WkRuemFlQndja1NSNGJvWjhzN0xOOUhEaHVrUHNodDFxODJoRkdHM1IrK0sr?= =?utf-8?B?eG1HbEJTREs1K2NpV1JlcTF3dm1zZz09?= X-Forefront-PRVS: 0324C2C0E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39850400002)(39410400002)(39400400002)(39450400003)(39840400002)(39860400002)(24454002)(377454003)(83506001)(31686004)(33646002)(42186005)(81166006)(7406005)(8676002)(230700001)(4001350100001)(189998001)(7416002)(23676002)(93886004)(53546009)(6246003)(47776003)(65956001)(50986999)(66066001)(6116002)(25786009)(7736002)(110136004)(3846002)(53936002)(305945005)(54356999)(76176999)(72206003)(54906002)(36756003)(86362001)(4326008)(2906002)(6486002)(31696002)(90366009)(77096006)(2950100002)(5660300001)(65826007)(38730400002)(50466002)(478600001)(6916009)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1150;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUwOzIzOmMvZWZWNis5TWd6SFlSV2xtM2RxdG9KM1ln?= =?utf-8?B?ZFQxMklUcGU1ZTlsa0RLeGZlSnJUVXJrQ3o5dFpsNmRvQzhyOXBiZ0RRZmVQ?= =?utf-8?B?NnNUWVpVN2dBL2k3SWp6K1ZXTG5qYlY2SnR2UG56cDZucFhaZU1SYi9xcFVR?= =?utf-8?B?WVBHTVZLRVNJSlNTNVBqVGNYcVMwenAvYWRVZnVVNC9rbzcyZ1BRbnpwVVhG?= =?utf-8?B?TUF1dzltWEU0UUdvdHRIck1zVlRmbXYvWnFqWkh6VlpyZktZWkV1bm8vaWxT?= =?utf-8?B?RWlHUXFSRW1kcnlSZXhDd2hhSHRvclFsc05idU1kWU5GOVE0WDRBanpyYnVw?= =?utf-8?B?Y2Q0bXpuNU5XVHA0V2dsM1FXdHdvZ29sRkZmRVNVQTBtNjdiSGJpbnNBSTFK?= =?utf-8?B?QmdKMUtqa2JVYmRwZ2VMZWx5WDlDS3l6YmJsSm85ZGo2Nkw0d0N4czVIWWR3?= =?utf-8?B?MWNKUXJ4cTJJVEZZQnNmZ2hkbVB1bXRLSzZUdzZGZTBNRmszNlIyalBTZjUw?= =?utf-8?B?TTBqd2RRWjlMcFRVaTFSU0N1Rkdrak5kN1JKd3J2aGpLbXBlVnBrbjkwTHVO?= =?utf-8?B?WDFYWG9QanB6L294WjdPM2xBODB0UEVKSEZueHY1L2w5MVhkdUdBMURDS1cy?= =?utf-8?B?eFI1S3h2S1VQcHpraldPQ01kUDF5ZitLQ3pua2F1bW0vdXBESDBmN0kyeDg4?= =?utf-8?B?TGdLcGNzUE5RVUZiWnJqTWhxVjVvejh3UVFFWWJDZlV4Z1VJK1MrRklTMlVS?= =?utf-8?B?akhrVDFOVmN2S0hrb3BKY3h2M0VVVHVSbTlQc1Y1SjJIU2s5Y1BRdnlTVUIv?= =?utf-8?B?ZzFhZ1YvQkFtQ252R25MTmZpZE05bmJrWTRpMHl5TjkwTktBci9BNU9GbHJm?= =?utf-8?B?M0tjQTltSlhTNmgxdUZaRzZxL1dpM3ZGNlJHaitRYjNwSWNnOHFYZzhENXdn?= =?utf-8?B?dzZHZzByT0UybzJuTUpGRUVuUE5HWUl4ejRWYU1vK1hIazhCZVl6bUZUSDY0?= =?utf-8?B?eUpsVEQrUEdLenBGaHI4WWVCMi9tY0t6S1ZRZFA4QVRvNnhoMm8zTjRNcmdO?= =?utf-8?B?VFN5RlZPT0w4T2NYRVA4NGVwcWVHY0Y2eGxaaWN6dlFMdVBBWGE4ME9WdlhK?= =?utf-8?B?WUtlYVRVRFpWSWszVkF0b3ZrR3J0Y2hiMU0rQVhFZmppSmRvZ240ZWJWU0NM?= =?utf-8?B?Y0t6aFBZN1EreUhjQWErc0ZUOFFKZDNKS3lvV2llVkp6TmtFZDdkUHA5Nkk1?= =?utf-8?B?NTVzR1Q3UmowRis2QkNyam9hMm9iVFNaSEd1VmlaSkthbXYxNXdGdmRFamor?= =?utf-8?B?UHRZYU1jUHFpWUF4eTk0VGpuR2lqK0NEK1cvdWs1TVN3V3NodldDN2w4aXJw?= =?utf-8?B?K2VLbFhENHp5KzVpVmh0RDFUOTlRb0EwQTVIdkR2MVNoYldRZmRXcXF3eG9G?= =?utf-8?B?SW55RXV3N1FKZVNDTjI1WHIvOHdFakVzbnY0ZE1TQmFrS2xORXd6a0JMYy9J?= =?utf-8?B?OGVDY0lnVWpnUmhMRnZhQnVkTDVvKzRBZjBiclNDOFI4em81SDI1bGRNSXpP?= =?utf-8?B?ZUlhSVRNdFFZbmxldW1oL2NycFlMVWpla3h1cXFlVzJRTXJ0VWh2YzlGN2JX?= =?utf-8?B?SlI5dUdYMGtnTlBsTlV2OEJ3NGtVT1pFSEFTVytPZ25PWENSQytuZDhaU1pU?= =?utf-8?B?WHYwRVFIdC9QdDhYZ2RJQmd2VFdMdEpZRzlLbGx1dm5TNGZKT0RhcS85Q2Nx?= =?utf-8?B?Mm9QVWRiNWtMVmJydEhDZytwNnUxUUhDTzd2elpUb0xlRG5PRGdKUFEwUjd3?= =?utf-8?B?Q1dQZWVCRjF5NjkvY3JWcnFDUExiVGY3TjI1Z0FObFBCcnYyaG9hUW5zc2gz?= =?utf-8?Q?/zOpTP3lVUC5EoJti2I6sBBOxunu+Vk8?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;6:SJ+JfncyeHEFvksKUgMDH2EWQUjMzXfGcwUDWpbTp+0DjaAXkStqLScZXMoZnERgasiI4bXb4GJYuQYzJT6x7tv7fUNvFFQlf/ikHemlhd/JvuGKQqY18JPtHaA9SqG916hUCHWyrs2m/tmMlX1N7g7P8AHBK0CfsDLF7l0ySFW5SWLqFCUUHIkkS6i31X4opIY+fZTDp2VysqgPPuzuv4dwNb1GkQ60GHbI/RZMub0c5Mjy8PS+IxfUN8NyeNF7lLX7hELSskNgufw9mQ48EWtb5ToCfRfBNNdivwIwfjytQOt7++tzKfaY4lFxA8uLE3ikuvQD1XXof5Y3voLqZ/eA1ch5I1f1Z5SPb78L1Dq5jv22CARUaYzy1MDerpkC3bVtPt+1f3OqjwncowDH0v3h+Xxnzih0gsVB2OdM2aYfhPkBixGhoNx8WSJSn8xbTJPz3HZ9e89jIoeiQuw77irhti+H9tlCmT71aog4p78WAugTIRhWg0k7FnObCBIpz5R4nqnqSV4aWqMqI++peshHaerRDTZ6wW22pdRGbwM= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;5:5DYzIvnbhSGlBbnRb8pYHXCzWMuzYxAFAW/BFBO3YBcbHzkct1jhjr4W8DVfISbfyNf77IisJSpnM/z0H419mxP78J4E0Cs+MdOwqJm829K/y3riwvgp2IBkYC/ySN31uqLo+UTSd96zfkipqzClWc/YEyPZ1JoviQjURhcXAdqhW2Si4EYKtFaH791sd5/gAj3zfSqaPGGgm6R0tCH+eXYvJIEX+jGTk9Oq9v2yBE7AW3afL/IoL2UBcTmR3UbHW2CJyzEHQWqU3a0PXWXX21jLlFYe66BeU/ztL7wcXlZqzL0oarFzesDSzZiRz0amtyUfsaUAUSACfENnehI/T2aYuYYe3/2UCCYFnYgXJgjt2wkYmkdV+oK/NauUy38KH+OQYzl5V3RMndIkzO0SBlIG1mbu/6YSf4ii1nJw+ufh0mu+JM05uUk4UPr27Ez6T/Wx7hM+ArqKTKTjgztpXeqzLDNxE9/QphGYpAgtbpn0/6mfU6kzeK3NwMdrC7tn;24:lHgpJvl7IT0hJ/hpnaB7RAgGYSObU5UKWdK7XiwJCRxIyRwVJp9Cl/Z3xac58TmX7FNGg9c9CiRc+bP2VmIILUT6FY7h7rbe9YL6VEjdfF8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;7:g4mLbE24krLj1Sq8K6dud3CS/BG1d63oVjw27sLK4qk2rNHcnE881/NlHEC9vb40XHoEeGzVB77QrELfec9+tfdfgRL3zIX/tNS8IjhrW0bzbOi7C2TSnzTpkbxuGCRElBIFeUkyNFf0AaV8RfWv8RI0Gsg2Uylt3fug+e70whpgmhn1qQ4xscHGYH2On13AX1jiLeAOQDLEc5uOw389mhHeNONwkKPNZhg+MQCA5Qxmx4FqDNN17pnInsjGHTLWvWnaMrHwRfxRl69/uYUORmeKqW3thaTkgtHRdwHStRTQDEkUhPLEA8tszOwo9sZ2Thu92CgdgaJARs10dGPIew==;20:86laBjiNQoI1TAfIElZDvp8c9/gk7mEBwhZDUDthndWuCXnnK0SQiAquFp3gYN6sqg3mvjwkQylv3l9JjQQPukV5Kevq0RL0jOslFOa73faqeYeiy3uDzfK6nh2SxxiiXCulhAM6+cM4VpJrtYuRSq95c79gNc4Bat6/T+En6QJHDyrjnl2qzHUvJD3w2nmkszSfA3mccehNmqFZiA9QIxrQsai7TfaCQq+Gn1StA15E3r1hSAEnRkMkbPJG0yTJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 13:37:53.4873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/2017 3:49 AM, Borislav Petkov wrote: > On Tue, May 30, 2017 at 10:37:03AM -0500, Tom Lendacky wrote: >> I can define the command line option and the "on" and "off" values as >> character buffers in the function and initialize them on a per character >> basis (using a static string causes the same issues as referencing a >> string constant), i.e.: >> >> char cmdline_arg[] = {'m', 'e', 'm', '_', 'e', 'n', 'c', 'r', 'y', 'p', 't', '\0'}; >> char cmdline_off[] = {'o', 'f', 'f', '\0'}; >> char cmdline_on[] = {'o', 'n', '\0'}; >> >> It doesn't look the greatest, but it works and removes the need for the >> rip-relative addressing. > > Well, I'm not thrilled about this one either. It's like being between a > rock and a hard place. :-\ > > On the one hand, we need the encryption mask before we do the fixups and > OTOH we need to do the fixups in order to access the strings properly. > Yuck. > > Well, the only thing I can think of right now is maybe define > "mem_encrypt=" at the end of head_64.S and pass it in from asm to > sme_enable() and then do the "on"/"off" comparsion with local char > buffers. That could make it less ugly... I like keeping the command line option and the values together. It may not look the greatest but I like it more than defining the command line option in head_64.S and passing it in as an argument. OTOH, I don't think the rip-relative addressing was that bad, I can always go back to that... Thanks, Tom >