From: Guenter Roeck <linux@roeck-us.net>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>,
Luca Tettamanti <kronos.it@gmail.com>,
Cosmo Chou <cosmo.chou@quantatw.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: use named initializers for acpi_device_id
Date: Tue, 15 Sep 2026 07:58:13 -0700 [thread overview]
Message-ID: <70746c77-e113-4bc6-93b6-7ac6027c86a4@roeck-us.net> (raw)
In-Reply-To: <20260915-acpi-hwmon-v2-1-39d17c748eb6@thegoodpenguin.co.uk>
On 9/15/26 06:48, Pawel Zalewski wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
>
It also replaces pointers to empty strings with NULL pointers,
which is a functional change and still neither documented nor explained.
Guenter
next prev parent reply other threads:[~2026-09-15 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 13:48 Pawel Zalewski
2026-09-15 14:58 ` Guenter Roeck [this message]
2026-09-16 14:33 ` Pawel Zalewski
2026-09-16 15:07 ` Guenter Roeck
2026-09-16 15:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70746c77-e113-4bc6-93b6-7ac6027c86a4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cosmo.chou@quantatw.com \
--cc=kronos.it@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pzalewski@thegoodpenguin.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®