From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-32.mta0.migadu.com [91.218.175.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 708994F5DEA for ; Tue, 29 Sep 2026 10:13:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790676832; cv=none; b=OlnICYZoftNQfpwz8LYkRsl10c2IAApE81IbMyCw59+rAZkCgDVGCuTBcZdFXFoYp+MIueTui9WnhTBVuJ+zlqCjVfy+i2Q4jwE0NCbFH8Nvtxo5mYwNorb4aC0P3SJ4pWka2DrR/DaCkur1vvCXZrDxM7Q+KVAQ1IG0tvJb9Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790676832; c=relaxed/simple; bh=FVlzfY3mMI+cjE7IoFuxnOjWAGKF39Gc3wStknwBDcU=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=mNaDc0K6HcuQh/JK9j1eRL5Pf8/Oxf0oL6zvYFPSh+F1GIX/5epP6lbYo83M5GYOhMKEHIefEmjIR6RGpJmff63I+nmH7D+wWjbJRNtQQyCNGKhG/5IwQ/nvHnNpOb4K+u5rOAOhZIVsFaMJnEJhG8kgbmawKRqwz4S67ODYg44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=prRS00vI; arc=none smtp.client-ip=91.218.175.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="prRS00vI" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=FVlzfY3mMI+cjE7IoFuxnOjWAGKF39Gc3wStknwBDcU=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790676823; v=1; x=1791281623; b=prRS00vITx6NwuWr8tP1pu1EpRYXxXOcxUPRSeMaEZGT+9yu49V+wChBK7uvJty0qqVab0IU NHts4U9n0ufuSivpPK/WSlp2gGLhmf8H/wN4529f49oBwwwgbnmPhJt8Vxmnt7AmPQf1RajX2LU EO9skOlFWf1C8qok2owPpiCA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 08322818c73fa8ab; Tue, 29 Sep 2026 10:13:43 +0000 X-Mizu-Trace-ID: 08322818c73fa8ab X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 29 Sep 2026 10:13:43 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Luka Gejak" Message-ID: <70785221599240049a8747750b6cf0369f8368d5@linux.dev> TLS-Required: No Subject: Re: [PATCH v4 3/6] wifi: rtw88: 8723b: add the RTL8723B chip driver To: "Bitterblue Smith" , "Ping-Ke Shih" Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael Straube" , "Peter Robinson" , luka.gejak@linux.dev In-Reply-To: References: <20260923213557.186205-1-luka.gejak@linux.dev> <20260923213557.186205-4-luka.gejak@linux.dev> <6ad11268-9f09-4618-8b44-ab0744cf0a52@gmail.com> September 27, 2026 at 19:29, "Bitterblue Smith" wrote: >=20 >=20On 27/09/2026 18:21, Bitterblue Smith wrote: >=20 >>=20 >> On 24/09/2026 00:35, Luka Gejak wrote: >>=20 >>>=20+ if (rtw_hci_type(rtwdev) =3D=3D RTW_HCI_TYPE_SDIO) { >>> + rtw_write16_set(rtwdev, REG_PWR_DATA, >>> + BIT_EEPRPAD_RFE_CTRL_EN); >>> + >>> + /* >>> + * rtw_mac_power_on() sets PAD mux bits this chip must not have; >>> + * restore the SDIO PAD mux before RF and coex setup. >>> + */ > By the way, rtw_mac_power_on() doesn't touch REG_PAD_CTRL1 > for this chip. It does, through rtw_mac_pre_system_cfg(), which rtw_mac_power_on() calls at mac.c:382. At mac.c:111 that function reads REG_PAD_CTRL1, ORs in BIT_PAPE_WLBT_SEL and BIT_LNAON_WLBT_SEL and writes it back, for every HCI type including SDIO. So the bits are set during power on and the SDIO PAD mux has to have them cleared, which is what rtw8723b_sdio_restore_pad= _ctrl() does. The comment in rtw8723b_post_enable_flow() names that function and = the two bits now. Best regards, Luka Gejak