From: Song Liu <songliubraving@meta.com>
To: NeilBrown <neil@brown.name>
Cc: "Tingmao Wang" <m@maowtm.org>, "Mickaël Salaün" <mic@digikod.net>,
"Song Liu" <song@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"brauner@kernel.org" <brauner@kernel.org>,
"Kernel Team" <kernel-team@meta.com>,
"andrii@kernel.org" <andrii@kernel.org>,
"eddyz87@gmail.com" <eddyz87@gmail.com>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"martin.lau@linux.dev" <martin.lau@linux.dev>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"jack@suse.cz" <jack@suse.cz>,
"kpsingh@kernel.org" <kpsingh@kernel.org>,
"mattbobrowski@google.com" <mattbobrowski@google.com>,
"Günther Noack" <gnoack@google.com>
Subject: Re: [PATCH v5 bpf-next 0/5] bpf path iterator
Date: Fri, 27 Jun 2025 00:21:23 +0000 [thread overview]
Message-ID: <707D80F3-9EEC-4108-8F8D-0BE069133E35@meta.com> (raw)
In-Reply-To: <175097828167.2280845.5635569182786599451@noble.neil.brown.name>
> On Jun 26, 2025, at 3:51 PM, NeilBrown <neil@brown.name> wrote:
[...]
>> Unfortunately, the BPF use case is more complicated. In some cases,
>> the callback function cannot be call in rcu critical sections. For
>> example, the callback may need to read xatter. For these cases, we
>> we cannot use RCU walk at all.
>
> I really think you should stop using the terms RCU walk and ref-walk. I
> think they might be focusing your thinking in an unhelpful direction.
>
> The key issue about reading xattrs is that it might need to sleep.
> Focusing on what might need to sleep and what will never need to sleep
> is a useful approach - the distinction is wide spread in the kernel and
> several function take a flag indicating if they are permitted to sleep,
> or if failure when sleeping would be required.
>
> So your above observation is better described as
>
> The vfs_walk_ancestors() API has an (implicit) requirement that the
> callback mustn't sleep. This is a problem for some use-cases
> where the call back might need to sleep - e.g. for accessing xattrs.
>
> That is a good and useful observation. I can see three possibly
> responses:
>
> 1/ Add a vfs_walk_ancestors_maysleep() API for which the callback is
> always allowed to sleep. I don't particularly like this approach.
>
> 2/ Use repeated calls to vfs_walk_parent() when the handling of each
> ancestor might need to sleep. I see no problem with supporting both
> vfs_walk_ancestors() and vfs_walk_parent(). There is plenty of
> precedent for having different interfaces for different use cases.
I prefer option 2.
>
> 3/ Extend vfs_walk_ancestors() to pass a "may sleep" flag to the callback.
> If the callback finds that it needs to sleep but that "may sleep"
> isn't set, it returns some well known status, like -EWOULDBLOCK (or
> -ECHILD). It can expect to be called again but with "may sleep" set.
> This is my preferred approach. There is precedent with the
> d_revalidate callbacks which works like this.
> I suspect that accessing xattrs might often be possible without
> sleeping. It is conceivable that we could add a "may sleep" argument
> to vfs_getxattr() so that it could still often be used without
> requiring vfs_walk_ancestors() to permit sleeping.
> This would almost certainly require a clear demonstration that
> there was a performance cost in not having the option of non-sleeping
> vfs_getxattr().
For built-in kernel code, I can see this works. However, I don’t see
why it is necessary to introduce the extra complexity of -EWOULDBLOCK,
and vfs_get_xattr_cannot_sleep, etc. A separate step-by-step walking
API is much cleaner.
>
>>> I strongly suggest you stop thinking about rcu-walk vs ref-walk. Think
>>> about the needs of your code. If you need a high-performance API, then
>>> ask for a high-performance API, don't assume what form it will take or
>>> what the internal implementation details will be.
>>
>> At the moment, we need a ref-walk API on the BPF side. The RCU walk
>> is a totally separate topic.
>
> Do you mean "we need step-by-step walking" or do you mean "we need to
> potentially sleep for each ancestor"? These are conceptually different
> requirements, but I cannot tell which you mean when you talk about "RCU
> walk”.
To be extra clear, I mean we need "step-by-step and
take-reference-on-each-step walking”, for existing use cases.
In the future, if it is possible to have a “do-not-take-reference,
cannot-sleep, callback-based walking”. We may try to use that for
some use cases. But that won’t replace step-by-step walking for
all users.
Thanks,
Song
next prev parent reply other threads:[~2025-06-27 0:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 6:11 Song Liu
2025-06-17 6:11 ` [PATCH v5 bpf-next 1/5] namei: Introduce new helper function path_walk_parent() Song Liu
2025-06-18 1:02 ` kernel test robot
2025-06-24 12:18 ` Jan Kara
2025-06-24 17:37 ` Song Liu
2025-06-25 10:30 ` Jan Kara
2025-07-04 17:40 ` Yonghong Song
2025-07-06 23:54 ` Song Liu
2025-07-07 17:53 ` Yonghong Song
2025-06-17 6:11 ` [PATCH v5 bpf-next 2/5] landlock: Use path_walk_parent() Song Liu
2025-07-03 18:29 ` Mickaël Salaün
2025-07-03 22:27 ` Song Liu
2025-07-04 9:00 ` Mickaël Salaün
2025-07-06 22:29 ` Song Liu
2025-07-07 10:28 ` Christian Brauner
2025-06-17 6:11 ` [PATCH v5 bpf-next 3/5] bpf: Introduce path iterator Song Liu
2025-06-17 6:11 ` [PATCH v5 bpf-next 4/5] selftests/bpf: Add tests for bpf " Song Liu
2025-06-17 6:11 ` [PATCH v5 bpf-next 5/5] selftests/bpf: Path walk test Song Liu
2025-06-20 21:59 ` [PATCH v5 bpf-next 0/5] bpf path iterator Song Liu
2025-06-24 18:45 ` Mickaël Salaün
2025-06-24 21:38 ` NeilBrown
2025-06-25 13:14 ` Mickaël Salaün
2025-06-25 23:04 ` NeilBrown
2025-06-25 23:17 ` Song Liu
2025-06-26 0:07 ` Tingmao Wang
2025-06-26 1:05 ` NeilBrown
2025-06-26 5:52 ` Song Liu
2025-06-26 9:43 ` Mickaël Salaün
2025-06-26 14:49 ` Song Liu
2025-06-26 10:22 ` NeilBrown
2025-06-26 14:28 ` Song Liu
2025-06-26 22:51 ` NeilBrown
2025-06-27 0:21 ` Song Liu [this message]
2025-07-07 10:46 ` Christian Brauner
2025-07-07 11:17 ` Christian Brauner
2025-07-07 18:50 ` Song Liu
2025-07-09 16:06 ` Mickaël Salaün
2025-07-09 17:31 ` Song Liu
2025-07-09 22:24 ` NeilBrown
2025-07-09 22:50 ` Song Liu
2025-07-10 0:58 ` NeilBrown
2025-07-10 6:28 ` Song Liu
2025-07-14 21:09 ` Song Liu
2025-07-24 17:35 ` Mickaël Salaün
2025-07-26 9:52 ` Song Liu
2025-07-09 22:14 ` NeilBrown
2025-07-09 22:41 ` Song Liu
2025-07-10 0:58 ` NeilBrown
2025-07-07 10:43 ` Christian Brauner
2025-07-03 5:04 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707D80F3-9EEC-4108-8F8D-0BE069133E35@meta.com \
--to=songliubraving@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gnoack@google.com \
--cc=jack@suse.cz \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=mic@digikod.net \
--cc=neil@brown.name \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®