From: YueHaibing <yuehaibing@huawei.com>
To: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>, <treding@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] firmware: tegra: Fix build error while ARCH_TEGRA_234_SOC enabled
Date: Fri, 11 Jun 2021 20:20:54 +0800 [thread overview]
Message-ID: <708178d9-e842-bac0-2f48-c6ce81aaee54@huawei.com> (raw)
In-Reply-To: <20210611120636.28252-1-yuehaibing@huawei.com>
Pls ignore this
On 2021/6/11 20:06, YueHaibing wrote:
> drivers/firmware/tegra/bpmp.c:861:51:
> error: ‘tegra186_soc’ undeclared here (not in a function); did you mean ‘tegra_ivc’?
> { .compatible = "nvidia,tegra186-bpmp", .data = &tegra186_soc },
> ^~~~~~~~~~~~
> tegra_ivc
>
> Add missing ifdef block to fix this.
>
> Fixes: 0ebdf11699d0 ("firmware: tegra: Enable BPMP support on Tegra234")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/firmware/tegra/bpmp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index 0742a90cb844..5654c5e9862b 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -809,7 +809,8 @@ static const struct dev_pm_ops tegra_bpmp_pm_ops = {
> };
>
> #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \
> - IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC)
> + IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> + IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
> static const struct tegra_bpmp_soc tegra186_soc = {
> .channels = {
> .cpu_tx = {
>
prev parent reply other threads:[~2021-06-11 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 12:06 YueHaibing
2021-06-11 12:20 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708178d9-e842-bac0-2f48-c6ce81aaee54@huawei.com \
--to=yuehaibing@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®