From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 192C53101A2 for ; Wed, 25 Feb 2026 08:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772006424; cv=none; b=jLZVd8cKgmvZ1H8eoFzEFvtyez3PgL1dUNX4ZfAP1M9moC+NxkMkjiJDBzGZO3lkd5zoczrhqSrM7ZgzIC+6XEODqlRdtZZe9GWog9d1bk0DOcu0e9Ve10qQ1KAEIi6dSYozwludqUvJzo01u91QcsPVoYBaCQeog2HxuyUhjE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772006424; c=relaxed/simple; bh=WAlLQFuiG46G63OWi71Ya5Oaz2Q09IfpFd9OYK0/v7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uCP7Jr3kOI6HutsrP5+FozeZU28dVO9dGpSedgJBNHNIs9LZpbL6+eIkgm76btYShLw5mvNt998oX9LUq9hJZpdjKxL7+eMYtpN+Pbx4ZsCPfXeKtnuOrUOocwswkYsZB5mJo7YOZgeGKflXkOsHstRbkBnU0E8A33N6tmTsMAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LV+QCZw9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GJ/CDqN2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LV+QCZw9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GJ/CDqN2" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P4I0ZI3333590 for ; Wed, 25 Feb 2026 08:00:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7GyPCX4s3bHnIw6xPuH3MulLGRJovVoI+WeruDlF4W0=; b=LV+QCZw9aL3iEixL r7NFIN1SEreU3z3DzMdkpU7rKnrHrymZKxN9+4dlMmJcyEuz0B29ahlwLHyeVePw 1RFm0cF66sPBJpKy9ewJZcr1mzyDLcgkhMXfwezJ8n6HJPRY3SKXZHsC5MeNYV9b XfY3u37VTP0ddXsyvnFoM7437z7h5H/nmF4h17nJ/XJdJ5pw4VKD8q/K9F4Dg7is NqSpQKQ2CqyelFzPFSS51zk302h+ujXktnJBW04qZxZRUpXJAyaK8t38hjVA+NXP QRzAux/U1/gtXr0REYOV4utGzLv4L3cmhBhUrEc43X7EcOZm7b30VCsKzxjoGT6Z 8X3h1A== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chh4724jf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 08:00:21 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8243fc3fe8eso21090951b3a.1 for ; Wed, 25 Feb 2026 00:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772006421; x=1772611221; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7GyPCX4s3bHnIw6xPuH3MulLGRJovVoI+WeruDlF4W0=; b=GJ/CDqN2o5wxyH2sE1eqbuNCI9zBXRFwdR971I+vzQGR/nGfZU582gxIDdtJrxmZ2R IzZ8e/EScy8RMzhVEmG1UaBAkW2cRf08EOcxDPu8B+TjT8Yg85dajgyKlY6Q7XCEqOb2 uUX4D7kyS3QYC+W9GStijXjTeNZHu+O8vmShBpE2GfUQmU8lpyAmJBRSaCHgN+w2yg9W JEPmYPTI3QHJ0AjpuoCU0vGxJWXiAREnFQjhL123p0n23Tu0Vymkn4a+7SMuji12Gzxq ysCfo8+ds33XNz4Mgtp8X6zydTWVowFqvVnnju/K5hUdPe3CWDd7QgBiz5lxaClv50EI SEIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772006421; x=1772611221; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7GyPCX4s3bHnIw6xPuH3MulLGRJovVoI+WeruDlF4W0=; b=J1K/kYmC6BTs6XwAKsJ8v10lmR+xAjqxp+XOY1UL5ED5T/5y5/wE+XzjOIVk1o+G1H 5qj5nxBQA/6UMnJOdDRqLlBWzpT06WQuGAUkleQav3hbAMgUA8L4re4zIELarHY/F27o b6hOGzc6HUmRsxVyscMZSsklnLAb/NOQZ4WdHGZOTv/TkNhv/bcQAvHst+b1PWMQf72w ayGdIH+vlZrf4qJIGY6pT1WrPsT03EWqiZwOn2SA8NJZkzuWdIVqtXqdp+bcNeA8bQ9g /4HzDYILsCR9Fu2FdYklKHua7M2DbRgk156KaEUWWuaP694LPpw1+FsDxnaNjRxcy2h4 x1IA== X-Forwarded-Encrypted: i=1; AJvYcCW1UmvPb5L3vSRChE4vuAMTYnOlS6c1xtP/WF4BQJI1jWogTgX3+yi83pNYgR/t2iSiwhEbNyRHfPUjTXI=@vger.kernel.org X-Gm-Message-State: AOJu0YzoEFmkiYES/tNcOAK1LGkGTenN1bbSg5j4B67qEuwgXMNcKhAW 6KMC+YcO0LwDjYQbhkDRYOI7vuMmqZWC4oa/pYPS1Gp+mQ5UO+yB5/jNyyOEqWYrc+qyl027XzY 5Yjso+aI0XwXQC3fnas2/kqszfJRM4mE5iGo7DT6dUCeVC+W9sQIsQDl87nvrXSk99LI= X-Gm-Gg: ATEYQzydkDau+pCcbqa7Ir2KybTHAbCMgDYy+lrz4Z4Pi22wdVoQQTM4EeeXXf9AILW jYa96S4EHR2UHBUV7DFHBmsOOsWtgri0eNaiXY5R2RwzUr9BPnP5snUxj/6LHTyo/8mHvwG9s3F pYjt/0mnp7TF310YfPov0eY/1nhkYiV4Pk42vQOt/5YY58/BhRp1Gdkmbi6THEcTcax/Vcn39Qc LD9ak9r8MjIIxbR/4euoxsDioIzi75CuxnviErcuQCyKjFv3U1iFoNPuG+40fef2tXxcdi85oWA P76XaHxalDAKHtB+4MMhwWLhNI92S/8wFU6gpuCEHGSwnQZv+kuS+JiYPDht5jFwGMS8eX3kS7e LYkm6oB4T/EuZY65v/E/Vyl4V7ceA8fgMkJtts2Galaqew8kUHc/+4IbYYeFNoc+g+MdEKSCJk8 6Zf+7viQ+wj15iJjrH X-Received: by 2002:a05:6a00:2e16:b0:7ef:d070:df1e with SMTP id d2e1a72fcca58-826da8bde47mr14214868b3a.3.1772006421154; Wed, 25 Feb 2026 00:00:21 -0800 (PST) X-Received: by 2002:a05:6a00:2e16:b0:7ef:d070:df1e with SMTP id d2e1a72fcca58-826da8bde47mr14214809b3a.3.1772006420313; Wed, 25 Feb 2026 00:00:20 -0800 (PST) Received: from [10.133.33.74] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd692b99sm13116288b3a.24.2026.02.25.00.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 00:00:19 -0800 (PST) Message-ID: <70824913-ab52-4737-ae49-50cbe6251e4c@oss.qualcomm.com> Date: Wed, 25 Feb 2026 16:00:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support To: Konrad Dybcio , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-3-231882bbf3f1@oss.qualcomm.com> <845165e6-4595-41de-8cff-d065e8f6b6be@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 8EH3IsX7i83T1o-BptnnrjQzC1A774oj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDA3NyBTYWx0ZWRfX6BJ35adqbRiY J+prqiTAyr6BIkLkD2qqAc36UwZ2nHWKDzXG3bdRfndmnUuj0U96z6MkbJDGmpAI1TizNJynksZ me+ueSM73HEDUqcGLRhsgSUsatjuMEvsIgWyo7O2/RZkNytbcprxJf2qdv6gvasPAQ1dWloxW/e az7UFbtNGY0zMKMHXjsCMuxrHIKHWJJW/ohk1L+ZCmGv88rJnU057m3z/Rx2r1dYYzv/MmAZBxQ fEkn3G3r2PDrrZczhty3S5v+j2w1wmlg3ibUYgYa6ohcNYWv5pKhNlwsJS6kKB7+mNLk1+SixCE fqhMQtK6+kPGL8YfuyuLB7A7Yl8cOp6xpekfmnuUhV0gqH6AdGp3vAU9cu6rTMYlSAEBItjHe/I pmeTVVnUnOfRt2Ti3TsNmvHkX7voERvKxAa1ziWLHBjy1qtp6ZvMEd3f+viwZCglAVXs/ie5pW3 psosU47aC30mIfSNHxg== X-Authority-Analysis: v=2.4 cv=fvDRpV4f c=1 sm=1 tr=0 ts=699eac15 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=7HR7IauXUe_kPJgae54A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: 8EH3IsX7i83T1o-BptnnrjQzC1A774oj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_03,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250077 On 2/13/2026 7:06 PM, Konrad Dybcio wrote: > On 2/10/26 11:29 AM, Yongxing Mou wrote: >> >> >> On 2/6/2026 7:02 PM, Konrad Dybcio wrote: >>> On 2/5/26 10:20 AM, Yongxing Mou wrote: >>>> Add DP/eDP switch support by splitting the PHY swing/pre-emphasis tables >>>> into separate DP and eDP configurations. This allows the driver to select >>>> the correct table based on the is_edp flag. >>>> >>>> Add a dedicated table for the SC7280/glymur platforms, as they are not >>>> compatible with the others. >>>> >>>> Signed-off-by: Yongxing Mou >>>> --- >>> >>> [...] >>> >>>> +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = { >>>> +    { 0x0b, 0x11, 0x16, 0x1b }, >>>> +    { 0x0b, 0x19, 0x1f, 0xff }, >>>> +    { 0x18, 0x1f, 0xff, 0xff }, >>>> +    { 0x1f, 0xff, 0xff, 0xff } >>>> +}; >>>> + >>>> +static const u8 edp_pre_emp_hbr2_hbr3_v3[4][4] = { >>>> +    { 0x0c, 0x15, 0x19, 0x1e }, >>>> +    { 0x09, 0x14, 0x19, 0xff }, >>>> +    { 0x0f, 0x14, 0xff, 0xff }, >>>> +    { 0x0d, 0xff, 0xff, 0xff } >>>> +}; >>> >>> This is not quite in line with docs for kodiak. Now, if you have >>> better/newer sequences than the HPG, I'm not objecting, but please >>> cross-check >>> >>> the rest of this patch I think looks fine >>> >>> Konrad >> Thanks for point that.. >>>> +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = { >>>> +    { 0x0b, 0x11, 0x16, 0x1b }, >> here should be { 0x06, 0x11, 0x16, 0x1b }, arr[0][1]: 0x0b->0x06 >> does this looks fine? will check tables again.. > > For kodiak I see: > > eDP HBR23 / low vdiff: > > swing > 0x0b, 0x11, 0x17, 0x1c > 0x10, 0x19, 0x1f > 0x19, 0x1f > 0x1f > > preemp > 0x0c, 0x15, 0x19, 0x1e > 0x08, 0x15, 0x19 > 0x0e, 0x14 > 0x0d > > (notice how that mostly differs by the lowest bit being (not)set vs > your proposal) > > eDP HBR23 / high vdiff: > > swing > 0x0a, 0x11, 0x17, 0x1f > 0x0c, 0x14, 0x1d > 0x15, 0x1f > 0x17 > > preemp > > 0x08, 0x11, 0x17, 0x1b > 0x00, 0x0c, 0x13 > 0x05, 0x10, > 0x00 > > Konrad Hi, this is different from what I saw. what i saw from kodiak HPG: eDP low vdiff (High HBR): 0x06, 0x11, 0x16, 0x1B 0x0B, 0x19, 0x1f 0x18, 0x1f 0x1f preemp 0x0c, 0x15, 0x19, 0x1e 0x09, 0x14, 0x19 0x0f, 0x14 0x0d eDP high vdiff (High HBR): swing 0x0a, 0x11, 0x17, 0x1f 0x0c, 0x14, 0x1d 0x15, 0x1f 0x17 preemp 0x08, 0x11, 0x16, 0x1b 0x00, 0x0c, 0x13 0x05, 0x10, 0x00 The set of values you provided looks more like data from LeMans / SC8280xp / glymur (low vidff). I’ll follow up by email later to confirm whether this is due to us using different HPGs. thanks.